Coder Social home page Coder Social logo

Clearer naming about acf-local-json-manager HOT 4 OPEN

khromov avatar khromov commented on August 11, 2024
Clearer naming

from acf-local-json-manager.

Comments (4)

khromov avatar khromov commented on August 11, 2024

@jonathan-dejong I agree with the label, but we wouldn't be able to have Twentysixteen (default behavior) because we don't know that the theme has the final say (it depends on load order and hook priority).

In fact, we can't even resolve the default path and show it as a tooltip because we use the same hook ( acf/settings/save_json ) to override the behaviour...

Maybe simply replace the current text with Default behaviour ?

from acf-local-json-manager.

jonathan-dejong avatar jonathan-dejong commented on August 11, 2024

@khromov Yeah I suppose that'd work. I didn't think of that.. However what would qualify as the default behavior then? When I set "disable overrides" what do you do? Remove all plugins where we have the save_json hook AND this plugins hook?

from acf-local-json-manager.

khromov avatar khromov commented on August 11, 2024

@jonathan-dejong Setting "disable overrides" only removes the override hook for this plugin ( https://github.com/khromov/acf-local-json-manager/blob/master/acf-local-json-manager.php#L21 ) , so the result will be a state as-if the ACF Local JSON Manager was not installed.

from acf-local-json-manager.

jonathan-dejong avatar jonathan-dejong commented on August 11, 2024

Ahhh okay I see :)

from acf-local-json-manager.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.