kherge / rs.aws-login Goto Github PK

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When using aws-login without having aws in PATH, a vague error message is displayed.

$ aws-login eks
The list of available EKS clusters could not be retrieved from the AWS CLI.
  No such file or directory (os error 2)

What is the expected behavior?

The application should detect that aws is not available and display a better error message.

$ aws-login eks
Please ensure that the AWS CLI is available in PATH.

Some additional context.

• The which crate could be used to check PATH.

It would be very handy to have a subcommand that simplifies the process of assuming and unassuming a role.

• Create an assume subcommand.
• Create an unassume subcommand.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The aws-login use prompt that is used to select a profile.

What problem is being solved?

I would like to make it easier to find a profile to use.

How would you like to see this problem solved?

The list of profiles to select from should be filtered by a text search against a full or partial match of the profile name.

Before

❯ aws-login use
? Please select a profile to use: ›
❯ profile-1
  profile-2a
  profile-2b
  profile-3
(Move up and down to reveal more choices)

After

❯ aws-login use
? Please select a profile to use: › 2
❯ profile-2a
  profile-2b
(Move up and down to reveal more choices)

Some additional context.

No response

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

Shell integration support.

What problem is being solved?

When switching profiles, the active profile is not automatically set when using Fish.

How would you like to see this problem solved?

Provide shell integration support for Fish.

Some additional context.

• Fish eval documentation.
• Fish login script documentation.
• Fish process substitution.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The application infrastructure.

What problem is being solved?

aws-login directly owns responsibility for how the application should be designed.

How would you like to see this problem solved?

Delegate this to a library dedicated for it, and possibly benefit from improvements made to the library over time.

Some additional context.

I am mostly dogfooding CarLI.

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When using the pull subcommand, an empty object is saved to the templates.json file.

What is the expected behavior?

When using the pull command, the downloaded templates should be saved to the templates.json file.

Some additional context.

• Running the command in admin mode does not change anything.
• Maybe reqwest is failing silently?

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The shell script installer.

What problem is being solved?

It is not convenient to read through the documentation to specify the desired shell integration.

How would you like to see this problem solved?

Use the SHELL environment variable to determine which shell integration option to use.

Some additional context.

No response

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When using pull to download the templates file, the configuration directory is not automatically created.

$ aws-login pull https://...
Could not save the downloaded templates.
  Could not write to the profile templates file: /Users/kherrera/.config/aws-login/templates.json
    No such file or directory (os error 2)

What is the expected behavior?

When working with the configuration directory, it is automatically created if it does not exist.

Some additional context.

Maybe the full path should be created in case the parent directory does not also exist?

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

Current build fails on the following command:

cargo build --release --locked

What is the expected behavior?

For the build to successfully complete.

Some additional context.

I introduced this issue when I pushed directly to master. Lesson learned.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The ability to create profiles from templates.

What problem is being solved?

Currently, profile templates can only be used to generate profiles of the same name.

How would you like to see this problem solved?

There should be a way to use any existing profile template to generate a new profile using any desired name.

With a new subcommand

aws-login new template-name profile-name

The purpose of the new command would be solely to use templates for new profiles of any name.

With an existing subcommand

aws-login use --as profile-name

The subcommand would check if the --as option is being used and either create a new profile from the selected template or copy an existing profile.

Some additional context.

No response

The following checks have been done.

• I could not find another feature request that covers what I need.
• This request does not cover existing functionality.

What problem is being solved?

Generating a token for authenticating with RDS IAM can be confusing and tedious.

How would you like to see this problem solved?

A subcommand could be created to handle prompting the user for the necessary information and then using to generate the token.

Some additional context.

Bonus points if you can get dropped straight into the respective database client in the terminal.

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When presented with a long list of profiles when running aws-login use, keyboard navigation through the list does not work.

What is the expected behavior?

For keyboard navigation to work properly as it does in other shells.

Some additional context.

No response

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

All error messages that are printed to the screen.

What problem is being solved?

It could be beneficial to use red font color so that users can immediately understand that something has gone wrong instead of coming to that conclusion after having read the message.

How would you like to see this problem solved?

Whenever an error message is printed to the screen, the red font color should be used.

Some additional context.

No response

It would be very handy to have a subcommand that will download profile templates using a URL, and then saving it to where profile templates are normally stored.

• Create a pull subcommand.

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

The use subcommand produces an error if no existing AWS CLI profiles are found and the profile templates file does not exist.

$ aws-login use
Could not get a list of existing AWS CLI profiles.
  No such file or directory (os error 2)

What is the expected behavior?

The subcommand should detect this scenario and display a more elegant error message.

$ aws-login use
There are no profiles available.

Some additional context.

No response

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When you run the application and an error message is printed, all following text is now the same color as the error text. This persists even with other applications that are used.

What is the expected behavior?

The color should reset to their defaults after the error message is printed.

Some additional context.

No response

The following checks have been done.

• I could not find another feature request that covers what I need.
• This request does not cover existing functionality.

What problem is being solved?

Using AWS CLI to assume and assume roles can be tedious and confusing.

How would you like to see this problem solved?

A subcommand could be created to automatically handle shell environment changes required for assuming and unassuming roles.

Some additional context.

• AWS CLI assume-role command reference.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The documentation for integrating into PowerShell.

What problem is being solved?

Some PowerShell configurations may have their ExecutionPolicy undefined which prevents the integration script from being loaded.

How would you like to see this problem solved?

Update the documentation to help PowerShell users that get caught by this issue.

1. Check what the ExecutionPolicy is for CurrentUser.

   Get-ExecutionPolicy -List

2. Allow local scripts to be executed.

   Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned

Some additional context.

This appears to be a Windows specific issue beginning with PowerShell 6.0 (see -ExecutionPolicy documentation).

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The ability to generate an auth token for RDS Proxy IAM authentication.

What problem is being solved?

We currently cannot select an endpoint for an RDS proxy.

How would you like to see this problem solved?

Include the option of selecting an endpoint for a proxy (e.g. read/write, read-only, etc.).

Some additional context.

No response

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

All releases for macOS.

What problem is being solved?

The binaries are not signed and complicate the user experience in launching the application.

How would you like to see this problem solved?

Create and use a self-signed certificate to sign macOS releases.

Some additional context.

• Create self-signed certificates in Keychain Access on Mac

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

When running the application in PowerShell without any arguments, the help screen does not have any font color.

What is the expected behavior?

When running the application in PowerShell without any arguments, the help screen should have the same colors that other terminals support.

Some additional context.

• Color support in Windows only available in v3.0 of clap.
• Clap documentation.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The profile listing for selection.

What problem is being solved?

There are some profiles I use far more frequently than others. Sorting alphabetically may not be the most convenient way of listing the available profiles.

How would you like to see this problem solved?

Add an option to allow profiles to be sorted by how often they are used. When a profile is selected, increment an internal counter for it by one. The next time the profile list is presented, sort by that internal number for each profile in the list.

Some additional context.

No response

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

The application does not integrate into the correct PowerShell profile.

What is the expected behavior?

The application properly detects the active PowerShell profile and uses it for integration.

Some additional context.

• The application assumes that the profile is always in one location, which is not necessarily the case.
• A StackOverflow provided a nice explanation on how PowerShell profiles can be discovered.

It would be useful to have a subcommand that takes care of generating credentials to authenticate into an RDS cluster using IAM authentication.

• Create an rds subcommand.

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

Windows path separator is used in Windows when running in Git for Windows shell while running shell script installer.

What is the expected behavior?

Use the Unix path separator on shell script installation.

Some additional context.

No response

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

Shell integration support.

What problem is being solved?

When switching profiles, the active profile is not automatically set when using PowerShell.

How would you like to see this problem solved?

Provide shell integration support for PowerShell.

Some additional context.

• PowerShell on Linux documentation.
  • Installing PowerShell on Linux arm64.
• PowerShell Invoke-Expression documentation.
• PowerShell profiles documentation.

The following checks have been done.

• I could not find another enhancement request that covers what I need.
• This request does not cover existing functionality.

What existing feature needs to be enhanced?

The test workflow setup on GitHub.

What problem is being solved?

The test workflow is only running the test suite on Linux.

How would you like to see this problem solved?

The test workflow should run the test suite on all platforms releases are built for.

Some additional context.

No response

The following checks have been done.

• I could not find another bug report that covers what I discovered.
• This report does not request new features or enhancements.

What is the current behavior?

The current documentation does not clearly specify that SSO support is for AWS SSO, not other services such as Okta.

What is the expected behavior?

The documentation to explicitly state that SSO support is for AWS SSO.

Some additional context.

No response