Coder Social home page Coder Social logo

khan-mobile's People

Contributors

adamjernst avatar jasonrr avatar jeresig avatar kamens avatar lsavino avatar sophiebits avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

khan-mobile's Issues

Occasionally videos get in a stuck state

Occasionally, if you select a valid video after viewing a video that does not yet have an MP4 URL, the player is left in a "stuck" state. Only the white spinner and a black background is visible. Waiting never shows the video player.

Video Tracking Duplicated

We're attaching a new video tracking object every time a new video is loaded but aren't unloading the old tracker, we need to fix this.

Border "shift" for highlighted <li> tags

When the border is added to an active

  • tag, the text and content inside shifts to the right 1px. I see that the CSS attempts to prevent this with an "auto" color border for inactive li and specifying a color for .active, but it is not working.

  • Indicators for subtitles

    This is probably on the TODO list, but we need a loading indicator and an error message indicator.

    Allow retrying download

    If download_error is specified in download_status, then the video download failed when it was most recently tried.

    Currently the "Download" button is disabled in this state. Please enable it.

    It's not necessary to display the error message as the native app takes care of that.

    Point count often doesn't update

    It is quite frequent for me to notice that the point count doesn't update. I don't have a more specific repro, but I'm definitely logged in.

    Can you insert some logging to figure out what's going on? Either using the existing "log" function with the div, or a khan:// update url with log= param.

    Can't tap anywhere in the row for subtitles

    I can only tap on the text directly, not anywhere on the row (blank space on the right). For some reason my personal instinct is to avoid "covering" the text with my hand so I tap on the blank space.

    Clicking on subtitles doesn't do much when Replay is visible

    Adding the following to the subtitles.find("a").bind("click", function( e ) { (line 583) half-works:

    if ( $(player).is(":hidden") ) {
        hideReplay();
        $(player).show();
    }

    The video remains paused – seekFn isn't called, because isSeekable returns false for some reason. (Why is seekFn a global-ish and not a callback to seek?)

    transcript scrolls back to current video position too quickly

    Just tested the version on Youtube and it waits 30 seconds before scrolling back to your current position. I think that make sense. If you are scrolling around you are either

    a) bored and want to scroll something or
    b) probably trying to find something in the transcript which can actually take some time

    -webkit-overflow-scrolling touch support

    In iOS 5, we need to adopt the new "-webkit-overflow-scrolling: touch;" method. I tried to do this naively, but was unsuccessful. I did a test and UIWebView does support the property--there's some other interaction going on here.

    Replay button doesn't disappear

    It doesn't seem to accept the click (it goes through to the video player's play button instead) and then doesn't disappear when playing beings.

    Recover from video tag errors

    Catch errors and display appropriate error text overlaid on top of the video player. (Perhaps hide the video player.)

    Point accumulation/display updating not consistent

    It's hard to tell exactly what's going on here, but I am consistently getting into states where points seem to accumulate at random intervals or not at all. I think we have a bug as well as a need to increase the frequency with which we update the UI.

    last_second_watched sync code doesn't work (incorrect assumption)

    The last_second_watched sync code is reading from the wrong variable:

        pendingSeek = storage.seek[ id ] || status.last_second_watched || null;
    

    That should be status.user_video.last_second_watched. However this means more checks in case status.user_video is null; I'll let someone else handle doing that in a clean way.

    Replay Overlay

    Add in an overlay that allows the viewer to replay the video or navigate to next/prev video.

    Subtitle resizing acts weirdly

    Right now the code is using two separate offsets--14px and 45px--and on the device the bottom margin is frequently incorrect.

    UI flckering

    Split view UI flickers in honeycomb during page transitions

    Subtitle scrolling issue

    When playing a video, the subtitles scroll correctly (at first).

    However if you scroll with your finger to the bottom of the subtitle list while playing, the scroll view will subsequently scroll all the way to the top and then stay there. Even if you scroll back to where the proper playing area is, autoscroll is erratic and scrolls you to seemingly random parts of the transcript.

    Only give me actual action_results, not videolog

    Right now khan-mobile is sending native code the entire results of the videolog post.

    I just want to receive the "action_results" key.

    Also please use "action_results" not "action_result" for consistency (note s on end).

    Stopping a scroll selects the subtitle row under the finger

    Scroll the subtitle list with enough inertia to have it continue scrolling after you lift your finger. Then tap to stop the scrolling. The subtitle row under the finger is selected and the video seeks to that position; it should not be.

    Recommend Projects

    • React photo React

      A declarative, efficient, and flexible JavaScript library for building user interfaces.

    • Vue.js photo Vue.js

      🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

    • Typescript photo Typescript

      TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

    • TensorFlow photo TensorFlow

      An Open Source Machine Learning Framework for Everyone

    • Django photo Django

      The Web framework for perfectionists with deadlines.

    • D3 photo D3

      Bring data to life with SVG, Canvas and HTML. 📊📈🎉

    Recommend Topics

    • javascript

      JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

    • web

      Some thing interesting about web. New door for the world.

    • server

      A server is a program made to process requests and deliver data to clients.

    • Machine learning

      Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

    • Game

      Some thing interesting about game, make everyone happy.

    Recommend Org

    • Facebook photo Facebook

      We are working to build community through open source technology. NB: members must have two-factor auth.

    • Microsoft photo Microsoft

      Open source projects and samples from Microsoft.

    • Google photo Google

      Google ❤️ Open Source for everyone.

    • D3 photo D3

      Data-Driven Documents codes.