The dovecotauth's discuss from kgaughan

dovecotauth's Issues

Handle CONT better.

The current mechanism is a hack, but ought to work. The problem is, I don't know when it'll be triggered.

Implement Server <-> Master support in addition to Client <-> Server.

Tests!

There are currently no tests. In fact, I haven't even run the thing yet, just dashed it off.

Doesn't work with Python 3.7

You have marked it as work with Python 3, but i got some errors with Python 3.7:

by default unix socket file is read-only
dict hasn't iteritems()
base64... requires bytes

I got it working with these changes:

--- dovecotauth.py.bak	2019-01-27 17:45:18.996892541 +0100
+++ dovecotauth.py	2019-01-27 17:47:42.084990114 +0100
@@ -62,7 +62,7 @@
     if inet:
         sock = socket.create_connection(inet)
     try:
-        yield Protocol(service, sock.makefile())
+        yield Protocol(service, sock.makefile("rw"))
     finally:
         sock.shutdown(socket.SHUT_RDWR)
         sock.close()
@@ -193,7 +193,7 @@
                 del kwargs[prohibited]
 
         args = ["{}={}".format(key, value)
-                for key, value in kwargs.iteritems()]
+                for key, value in kwargs.items()]
 
         for flag, name in ((secured, 'secured'),
                            (valid_client_cert, 'valid-client-cert'),
@@ -201,8 +201,8 @@
             if flag:
                 args.append(name)
 
-        resp = self._SUPPORTED[mechanism](uname, pwd)
-        args.append('resp=' + base64.b64encode(resp))
+        resp = _SUPPORTED[mechanism](uname, pwd)
+        args.append('resp=' + base64.b64encode(resp.encode()).decode())
 
         self.fh.write("AUTH\t{}\t{}\tservice={}\t{}\n".format(self.req_id,
                                                               mechanism,

Figure out if the request ID counter should persist across sessions.

I think it probably should. If so, it'll need a class variable and a lock, which is nothing onerous, but something that I'd prefer not to do if possible.

Recommend Projects