kexpcapstone / shelves-server Goto Github PK

• We already have the 'Featured' flag in the Shelf struct, so this is just set at creation.
• But, we should have a way to get featured shelves

Make sure we have idiomatic status codes instead of just ISE.

To return that user's shelves? Right now we just have /v1/shelves/mine which returns the current auth user. Not sure what implications of exposing userIds is right now

Determine which (if any) services absolutely must have authentication before forwarding. I think for now, we can just blanket cover both library and shelves, assuming that everybody has an account

Not a high priority atm, but we could do it like this:

• Struct has an "Archived" flag
• Handlers which are match resource path like /shelves/archives/
• GET a user's archived shelves

If we are essentially doing a "replace" operation for updating shelves, we should remember that the front end needs to pass information about this edit time.

Has no associated handler, I don't think this should really be a priority for implementing on the front end.

Right now, only the shelves service requires authentication. We will need to put the library behind authentication to support posting notes.

In particular, if notes should be nested or not. I think that because we intend for notes to be associated with specific releases that it makes sense to have them nested. Additionally it would eliminate the need to fetch notes for a release after fetching a release. But, worthwhile to dicuss.

Take extra care in thinking of how to handle UserIds

• Mongo stores fields as lowercase--some of the mongo queries are capitalized so they will need to be changed

Python?

• Check if the release group id exists in results before adding
• But, how do we handle cases in which certain releases within a release-group actually have more or less tracks...? For example, M.I.A.

We need to evaluate exactly what information we want to get from MusicBrainz.

• Possibly being overwritten by AddToTrie
• Could have been related to dangling docker images

It's country right now but we should change it so it's consistent across the board.

Mongoimport needs to complete before starting our microservices:

use a wait-for script in docker-compose to fix this

We should be checking if the field has an empty value before we index it--I think we are probably ok but something good to evaluate. Adding a check if len(prefix) > 0 seemed to break it however.

Lots of artist names are stylized with a lower case first letter

• "of Montreal"
• "alt-J"

For grouping and sorting purposes we'd like case to be ignored
This needs to be specified as a collation in calls to the artists' collection in mongo

Lots of 502s are returned as is, would be nice to have some better handling of bad requests

• Is there a potential case to be made for allowing multiple adds?

Replacing or patching?

Crops up when dealing with notes and the user ends up getting signed out
That seems like there may be something wrong with the sessions library beause the request shouldn't even be forwarded to the library service...

For the handlers which check for authentication implicitly by decoding the X-User header, update the error message to reflect the fact that the user is not signed in (as opposed to a 400 status with a message of "error decoding JSON..." like it is now).

The current implementation actually deletes, so we don't really need this flag.

Some requests will end up saying 'Could not convert 'limit' param value ' ' to integer', even if the request did not include the limit query

This should be moved from a store to a handler function or something