kevinhinterlong / archwiki-viewer Goto Github PK

Use the MediaWiki API to get search results as you type in your search

WikiPageBuilder breaks on parsing page titles which don't contain " - ArchWiki"

I have translated your application into zh-rCN (Chinese (China)). Here is the xml:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="app_name">ArchWiki 查看器</string>
    <string name="menu_settings">选项</string>
    <string name="share">分享链接</string>
    <string name="search">搜索</string>
    <string name="exit">退出</string>
    <string name="text_size_preference">文字大小</string>
    <string name="refresh">刷新</string>
</resources>

Translation made with Stringlate.

This setting should have a slider to change the values instead of using the deprecated default values

update the html to the current wiki main page

Hardcoded string resources in WikiClient
Repeated String resources in strings.xml

When I take a look in the playstore I notice, that the app's current version is v1.0.11.

In the F-Droid store the current version is v1.0. 7. There's no "unstable"-marked version in the F-Droid store so far.

What's the reason for the difference on the versions? Is there a failure in build process?

Kind Regards,

Krawei

I have:

• searched open and closed issues for duplicates

Spanish (es) translation of app/src/main/res/values/array.xml is missing.
It's only 5 simple words. That could be translated via Google translator, but it would be ideal if someone who at least knows Spanish grammar looked at it.

I have:

• searched open and closed issues for duplicates
• provided a reproducible result if applicable

Bug description

It doesnt show the news but following text
"android.sax.BadxmlExeption: Line 2: Root element name does not match. Expected rss w3.org/2005/Atom:feed"

Steps to reproduce

• fdroid version
• open app
• wait while "one second please fetch data"
• error is shown.

Actual result:
error page "android.sax.BadxmlExeption: Line 2: Root element name does not match. Expected rss w3.org/2005/Atom:feed"
Expected result:
showing news

Device info

Device: Razer Phone 1
Android version: 11
App version: 2.0

Studies have shown that mobile apps are prone to crashes due to a network issue, mainly because successful network calls return unexpected or no data. And we found that when this app (version 1.0.11)'s network returned data is null or some fields are null (JSON format), the app has crashed. the specific crash information is as follows:

java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:309)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
at java.util.concurrent.FutureTask.run(FutureTask.java:242)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.UnsupportedOperationException: JsonNull
at com.google.gson.JsonElement.c(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.data.SearchResultsBuilder.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.data.SearchResultsBuilder.b(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.Fetch$1.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.Fetch$1.b(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.FetchUrl.a(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at com.jtmcn.archwiki.viewer.tasks.FetchUrl.doInBackground(dalvik_source_comjtmcnarchwikiviewer_12.apk)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
... 4 more

Please, add to the README.md file a badge 'GET IT on F-Droid' badge with link to this app on F-Droid app store.

Suggesting upon app launch, instead of a blank page, it goes to the Arch Wiki main page.
https://wiki.archlinux.org/index.php/Main_page

@jtmcn, are you using the @ioos github account?
The only thing I saw there was a fork of archwiki-viewer.

If you aren't using it, would you be willing to give it up?
The US Integrated Ocean Observing System (IOOS) would love to have
github.com/ioos as an organization site.

Thanks,
Rich Signell, US Geological Survey

It would be a very neat feature if a user could add wiki pages to some sort of bookmarks or started pages.

This app is FOSS, why not available int F-Droid?

There are plenty of MediaWiki api tools written for java already, there's no need to duplicate this functionality in the app. This will also make it easier to add features like #24 #25

https://github.com/Wikidata/Wikidata-Toolkit
https://github.com/MER-C/wiki-java
https://github.com/WolfgangFahl/Mediawiki-Japi
https://github.com/fastily/jwiki

There was an update to the icons from #6 but it got switched out while updating. Let me know if you want to update to this icon.
Here's a preview

I'm trying to build the app with ant debug and I get this error:

res/layout/wiki_layout.xml:15: error: Error: No resource found that matches the given name (at 'src' with value '@drawable/ic_launcher')

Shouldn't there be an icon ic_launcher.png in each drawable-*dpi directory? If I copy and rename e.g. /ic_launcher-web.png the project builds successfully.
(I'm not sure, maybe I'm doing something wrong since I don't have much experience with Android, but I thought this was worth asking anyway)

Just noticed you can't actually share the first page that gets opened. This shouldn't be too hard to fix so I'll probably just add it

This is a pretty common thing in apps that hide the header on scroll. If it's easier to implement, perhaps an option to always show the header?

If you're not sure what I'm referring to, very slowly scroll at a uniform speed, alternating up and down; you'll see the scroll accelerate when the header moves.

I'd really like to have a toggle for a dark theme; AMOLED would be nice.

Right now the table of contents is hidden and I find it sometimes cumbersome to have to scroll to the middle or bottom of a long page while I could just use the table of contents to reach what I need. Please consider not hiding it.

Also make the header bar and "settings" panel implement material design would be really appreciated.

anything of the form url#section doesn't scroll to the appropriate section

I have:

• searched open and closed issues for duplicates
• provided a reproducible result if applicable

Bug description

When trying to share link of the current wiki page, the app crashes. No info provided, just a dialog telling that ArchWiki Viewer stopped and to close it.

Steps to reproduce

• Go to the any page in ArchWiki
• Tap on the ⋮ (vertical ellipsis) menu button
• Tap "Share link" menu item (or "Compartilhar link" in my pt_BR translated interface)

Actual result: app crashes
Expected result: open dialog to select how I want to share the link for that wiki page

Device info

Device: Samsung Galaxy A5 (2017), SM-A520F
Android version: 8.0.0
App version: 1.0.13
Language: Portuguese (Brazil)

I have noticed recently that if I browse the ArchWiki on my device using a browser (so not using archwiki-viewer), I get an additional android-like icon in the browser's address bar which, when clicked, opens archwiki-viewer.

I take it this is due to code in archwiki-viewer as opposed to code in the browser?

And it "looks" like browser connections are being tracked by archwiki-viewer or there is some trigger when visiting the the wiki url.with the browser.

This raises a security/privacy concern.

Can you please explain what is going on "behind the scenes" and what is the purpose of this "feature"? If one is already on the ArchWiki page in the browser, why would one need to open archwiki-viewer then?

It seems the value of archwiki-viewer is to be able to browse the wiki quickly without having the full browser open, etc.

Thanks.

Use the MediaWiki API to get the table of contents and link to different parts of a page.
https://wiki.archlinux.org/api.php?action=parse&format=json&page=Main_page

Since this would use anchors to move around, it would require #22 to be fixed first

Dear team,

when I take a look in the play store the current version is 1.0.11, in tbe F-Droid store the current version is 1.0.12. What's the reason for this gap? Is there a bug in thr build process?

Please fix this.

Kind Regards,

Krawei

MediaWiki API has a section for this
https://wiki.archlinux.org/api.php?action=parse&format=json&page=Main_page
This would change how we handle checking whether or not to override a URL

I have:

• searched open and closed issues for duplicates
• provided a reproducible result if applicable

Bug description

The default MediaWiki theme was changed to "Vector (2022)", which broke the in-app page (specifically the CSS?)

Steps to reproduce

• Open the application on device

Actual result: Page properly renders
Expected result: Page does not properly render, instead having most of the text on the page (including what's normally hidden in a side menu on mobile?) being left-aligned without proper formatting.

Device info

Device: Google Pixel 4a 5G
Android version: 13
App version: 1.0.14 (Installed via F-Drioid)

I have:

• searched open and closed issues for duplicates
• provided a reproducible result if applicable

Is it possible to you the official wikipedia app and change the app name and urls to arch wiki?

Requesting ability to download the wiki for offline viewing

WikiPageBuilder contains an extra </head>