Comments (4)
From @celsomtrindade on November 17, 2017 10:25
One note on this topic is normalize the name accros the project. For example, the module
is called BootstrapModal
, then the service
is called DialogService
. There are classes named modal
and others named dialog
.
There is also the fact that it's called "Bootstrap" and has a lot of references to the bootstrap project, but it works perfectly without any Bootstrap code at all. Maybe it's the case to remove any reference from Bootstrap, including it's own css styles (I can provide it) and make it depend only on Angular.
Note: On the Boostrap topic, do you think it's better to open another issue?
from ngx-simple-modal.
Well you raise some good points. Initially i think my goal would be to do as much as i can without any breaking changes. Ultimately we're talking about a module in npm with bootstrap in the title already though, so it probably a version 2.0.0.
To your note : Its probably right to open another issue, and peg it as a version 2.0.0 for now. If the autho of the original one doesn't come back by lets say 3 months from now, i'll ramp up this and start considering this its own thing (with credits in tact of course).
from ngx-simple-modal.
There is a good conversation which birthed this repo found here kevcjones-archived/angularx-bootstrap-modal#10
from ngx-simple-modal.
This is being done / done. Brough over for historical purposes. #4 takes over from this.
from ngx-simple-modal.
Related Issues (20)
- ComponentFactoryResolver issue HOT 4
- where to change modal fade color ? HOT 1
- Hide Modal visibility on page redirect HOT 2
- @angular-devkit/build-angular 0.803.3 HOT 3
- AutoFocus doesn't trigger if animationDuration is 0 HOT 3
- Dynamic modal classes HOT 5
- Angular 9: ngOnDestroy is not triggered (Ivy ng9) HOT 11
- error when installing HOT 3
- mapDataObject doesn't check for null values resulting in a TypeError HOT 1
- Component inside modal with @HostListener('document.click') doesn't work HOT 1
- Model does not trap focus HOT 4
- Not working with Angular 11 HOT 6
- wrapperClass does not apply class to simple-modal-wrapper HOT 1
- Getting Cannot read properties of undefined (reading 'split') on modal close HOT 2
- Double call of onClosing callback for a modal that is subscribed
- ReflectiveInjector is deprecated and will be removed in v14
- Only allow single instance of modal
- Passing data example
- Error when upgrading from angular 15 to angular 16 HOT 3
- Support for Angular V17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-simple-modal.