Coder Social home page Coder Social logo

Comments (4)

kevcjones-archived avatar kevcjones-archived commented on August 14, 2024

From @celsomtrindade on November 17, 2017 10:25

One note on this topic is normalize the name accros the project. For example, the module is called BootstrapModal, then the service is called DialogService. There are classes named modal and others named dialog.

There is also the fact that it's called "Bootstrap" and has a lot of references to the bootstrap project, but it works perfectly without any Bootstrap code at all. Maybe it's the case to remove any reference from Bootstrap, including it's own css styles (I can provide it) and make it depend only on Angular.

Note: On the Boostrap topic, do you think it's better to open another issue?

from ngx-simple-modal.

kevcjones-archived avatar kevcjones-archived commented on August 14, 2024

Well you raise some good points. Initially i think my goal would be to do as much as i can without any breaking changes. Ultimately we're talking about a module in npm with bootstrap in the title already though, so it probably a version 2.0.0.

To your note : Its probably right to open another issue, and peg it as a version 2.0.0 for now. If the autho of the original one doesn't come back by lets say 3 months from now, i'll ramp up this and start considering this its own thing (with credits in tact of course).

from ngx-simple-modal.

kevcjones-archived avatar kevcjones-archived commented on August 14, 2024

There is a good conversation which birthed this repo found here kevcjones-archived/angularx-bootstrap-modal#10

from ngx-simple-modal.

kevcjones-archived avatar kevcjones-archived commented on August 14, 2024

This is being done / done. Brough over for historical purposes. #4 takes over from this.

from ngx-simple-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.