Dynamic modal classes about ngx-simple-modal

[kevcjones-archived]

I liked your idea with a function that you could simply resolve it. Simplest change for the moment is better. Life cycle is a nice idea but probably I'd want more thinking time before opening that door. Sorry I've been pretty busy at work to sort this out. Appreciate all contributions in advance.

…

On Fri, 14 Feb 2020, 18:03 Asier Illarramendi, ***@***.***> wrote: I want to implement something to handle this scenario. What's the approach I should take so that you'll be confortable merging the feature? What do you think on having a callback on the config which decides which class to apply? Or maybe it would be more like a life-cycle hook where the library-user can patch the newly created modal. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#65>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJ54EB7JAEPT5MFFSNY4LRC3MHVANCNFSM4KII6XVA> .

[doup]

I want to implement something to handle this scenario. What's the approach I should take so that you'll be confortable merging the feature?

What do you think on having a callback on the config which decides which class to apply? Or maybe it would be more like a life-cycle hook where the library-user can patch the newly created modal.

[kevcjones-archived]

By the way - just a note to say it's really cool to see something unique made with this. You've pushed it further than i ever have 👏 👏 👏

[kevcjones-archived]

Did you manage to put a PR together for this?

[kevcjones-archived]

Closing until you comeback with something or i pick it up myself.