The hxdoom from kevansevans

hxdoom's People

Contributors

Stargazers

Watchers

hxdoom's Issues

Break up cores into packages and port over original C classes into those

Lumps now have lumpID property which is assigned on read assigned on read

Helper functions that return GL friendly values.

Wad cueing system. Way to track when all files have been added.

Flag property for classes that need it.

Ditch automatic initialization of cores. Have developers choose which parts are needed, should aid with DCE.

Revamp wall occlusion handling, adopt the 'range' method that allows for Float precision

Hi, I saw this repo via twitter. Very cool you managed to create Doom in Haxe 💯 Hope you dont mind but wanted to give some random feedback. now I haven't tried to compile the project but just looking at the code I noticed these things.

Instead of doing

	public static var WADDATA(get, null):WadCore;

//...

	static function get_WADDATA():WadCore 
	{
		return WADDATA;
	}

You can also do:

	public static var WADDATA(default, null):WadCore;

f you do want to use these kind of getters, I would advice to remove the public (to avoid using that getter directly) and add inline there, to avoid having the function call, so:

	public function get_xpos():Float 
	{
		return xpos;
	}

becomes:

	inline function get_xpos():Float 
	{
		return xpos;
	}

Instead of doing:

public static inline var

you can do:

public static inline final

Instead of doing: (I saw this in Patch.hx)

	public static var CONSTRUCTOR:(Array<Any>) -> Patch = Patch.new;
	
	public var width:Int;
	public var height:Int;
	public var offset_x:Int;
	public var offset_y:Int;
	public var pixels:Vector<Vector<Int>>;
	public function new(_args:Array<Any>)

You can just use

	public static var CONSTRUCTOR:(Array<Int>) -> Patch = Patch.new;
	
	public var width:Int;
	public var height:Int;
	public var offset_x:Int;
	public var offset_y:Int;
	public var pixels:Vector<Vector<Int>>;
	public function new(_args:Array<Int>)

There is no need I guess to use Any here, I would avoid this where possible.
I don't really see a reason why you need CONSTRUCTOR instead of just using Patch.new directly, or why not even just use new Patch(), so you could also remove the CONSTRUCTOR altogether and maybe even drop that array and use something like this

// ...
class Patch extends LumpBase
{
	public var width:Int;
	public var height:Int;
	public var offset_x:Int;
	public var offset_y:Int;
	public var pixels:Vector<Vector<Int>>;
	public function new(width,height,offset_x, offset_y) {
		super();
		this.width =  width;
		this.height =  height;
		this.offset_x = offset_x;
		this.offset_y = offset_y;
	}
// ...