Do not use gtk_dialog_run about gnomecast

[keredson]

the idle_add is necessary because we're triggering it outside the main loop. that will be required regardless.

i'm a pretty amateurish GTK dev. could you explain or link to an explanation why dialog.run() is worse than listening to a signal? i tend to do it when i can because it's just simpler code, but if i'm stepping on my own feet w/o knowing it i definitely want to know. docs https://developer.gnome.org/gtk3/stable/GtkDialog.html#gtk-dialog-run don't seem to suggest it's deprecated. also has this:

Note that even though the recursive main loop gives the effect of a modal dialog (it prevents the user from interacting with other windows in the same window group while the dialog is run), callbacks such as timeouts, IO channel watches, DND drops, etc, will be triggered during a gtk_dialog_run() call.

which would indicate it doesn't block the main loop, just creates a modal-like experience. (which i'm looking for here.)

[nacho]

I think this comment explains it quite well: https://blogs.gnome.org/desrt/2012/02/26/sprout-and-the-bean/#comment-1225

[keredson]

huh, that article is from 2012 and says:

we’re going to deprecate gtk_dialog_run() next cycle. (yay!)

i wonder why that didn't happen.