kentico / mvc Goto Github PK

As soon as I enable the Preview module in an MVC site, client cache settings are completely ignored.

To reproduce:

• Setup an MVC-only Kentico site using the Kentico Nuget packages
• Setup application initialization as done in sample apps like Dancing Goat (App_Start\Application.cs)
• Add an entry to the routing table to ignore static content
• Now request a page and observe the headers on static content like /Content/Styles/Site.css

Cache-Control: private

• setup client caching in web.config:

<staticContent>
       <clientCache cacheControlCustom="public" cacheControlMaxAge="1.00:00:00" cacheControlMode="UseMaxAge"/>
</staticContent>

• The response headers should now include this:

Cache-Control: public,max-age=86400

But it doesn't.

• Now disable the Preview module in App_Start\Application.cs

After that, caching works as expected for static content.

I've traced this back to line 59 in PreviewFeatureModule.cs.

context.Response.Cache.AddValidationCallback(ValidateCacheItem, null);

Commenting that line solves the issue. I'm not sure why that line is even there.
For static content, the event handler being registered is never hit.

Motivation

project.json is deprecated and SDK style projects are supported in .NET Standard, .NET Core and .NET Framework projects.

SDK style projects also provide

• The best Nuget package dependency resolution (the transitive dependency tree can be seen in VS references UI)
• Easier access to *.csproj files in VS (no need to unload, fewer merge conflicts through file globbing)
• PackageReference Nuget package manifest syntax (the recommended approach going forward)
• Global package store for users (faster package restore for common packages)

This could make it easier for developers external to Kentico to contribute to this repository.

Proposed solution

Convert all the .csproj files in this repo to SDK project syntax

Additional context

There are tools to help with this conversion
https://github.com/hvanbakel/CsprojToVs2017
And Nate McMaster blogged about the process
https://natemcmaster.com/blog/2017/03/09/vs2015-to-vs2017-upgrade/

Kentico 12 sample code for dancing got can i get because earlier version not working in kentico 12

I do follow to Readme but error

I config file Config:

Please support for me. Thanks

Original issue: Kentico/Home#2 submitted by https://github.com/mdaniels-chl

Went through the steps for both Learning Kit and Dancing Goat and both get an error.

For example, if a new column is added to the CustomerInfo class (i.e. CustomerTitle) then there is no way of using the Kentico.Ecommerce package to access those new columns and expose them through the Customer model.

It could be useful to amend the models to set the "OriginalCustomer" value to be a protected property which can be access by classes inheriting from Customer. This would allow us to create a custom Customer model which includes our extra columns.

This pattern could be applied to the other models in the various packages.