kennethlarsen / lannister Goto Github PK

Right now it starts at index 1 in the file array. This means it skips the first file in the directory.

Shit hits the fan when a line like below is found

function someFunc() { // TODO: Figure out what to do about the dragons }

So far there is nothing.

Noticed that you added the MIT license to source, but the license in package.json is still set to "ISC".

Allow users to customize rules

Right now we look for everything

Lannister should be able to check all JS files of sub folders in the root folder provided in lannister dir/

Nothing says techical debt more than

// TODO: ...

Add a warning if this is found.

Add a warning if a line is more than 80, 100 or 120 characters longs.
Maybe also add the line number in there?

The "dummy-files" folder made good sense prior to having tests, but now that we have that, I think we should remove the folder.

If such a folder is needed, it should be kept outside the Lannister repo.

Linters such as eslint can already report for log's.
But would it be an idea to also do a check for this?

It would be neat to see which line number that Lannister is reporting issues on.

So
- [x] dummy-files/file.js has TODO comment. Consider refactor. (todo-comment)

Becomes
- [x] dummy-files/file.js has TODO comment on line 34. Consider refactor. (todo-comment)

Currently the function-validator only supports function name() syntax.

With the flag -o

Inspired by reek we should add similar functionality to lannister: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Name.md