Coder Social home page Coder Social logo

Comments (4)

keepsimple1 avatar keepsimple1 commented on September 18, 2024

Since host_ipv4 is &str in ServiceInfo::new, we could add support specifying one or more ipv4 addresses in the same string, separated by , or some other separator. What do you think? (any other suggestions are welcome).

from mdns-sd.

indietyp avatar indietyp commented on September 18, 2024

Going with a string separated by , would be a good idea, but also adding methods like insert_address and remove_address for a more programmatic approach.

One could also imagine having an optional dependency on the ipnet crate, which provides access to an Ipv4AddrRange and Ipv4Net struct.

I'd be happy to create a pull request that implements those changes.

from mdns-sd.

keepsimple1 avatar keepsimple1 commented on September 18, 2024

Adding methods like insert_address and remove_address sounds good to me. I'm reluctant to add a new dependency for this purpose, unless something really useful.

Thank you for submitting the PR. Will take a look.

from mdns-sd.

indietyp avatar indietyp commented on September 18, 2024

#21 was merged, closing this issue

from mdns-sd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.