Comments (5)
Yes! INFO is preferred on my side, but for the sake of the project, I think WARN
might be the better choice. At whichever you prefer
from mdns-sd.
This library does not use async, can you please elaborate the details? And what do you mean by the receiver
and sender
here?
from mdns-sd.
the receiver
refers to the flume receiver when browsing a new service
let receiver = service_daemon.browse(service_name.as_ref()).with_context(|| {
let err_msg = format!("failed to browse for service: {}", service_name);
error!(error = err_msg);
err_msg
})?;
The sender of course, refers to the sender on the other side of the channel.
Flume supports async send and with the receiver trait
impl<T> Receiver<T> {
/// Asynchronously receive a value from the channel, returning an error if all senders have been
/// dropped. If the channel is empty, the returned future will yield to the async runtime.
pub fn recv_async(&self) -> RecvFut<'_, T> { <<-------------- This is returns a future
RecvFut::new(OwnedOrRef::Ref(self))
}
//....
}
and commonly, one may want to use tokio timeout for a maximum wait time. if timed out, we usually stop browsing, and the sender will fail to send an event as the tokio timeout drops the future after timed out.
from mdns-sd.
I see. The error refers to this one, right?
I assume that in your code it is not easy, or doesn't make much sense to read SearchStopped
event, right? As you already are in the process of drop after a time out.
As this is not critical error, we could reduce the logging level of this one to WARN or INFO. Is WARN
okay or no?
from mdns-sd.
Fix merged. Let me know if any problems.
from mdns-sd.
Related Issues (20)
- Allow the user to disable IPv6 if desired HOT 1
- Malformed mDNS query causes ServiceDaemon to panic HOT 2
- `.browse` for all subservice's HOT 9
- Not consistent shutdowns and no way to know if shut down? HOT 7
- Trouble with query_missing_srv() HOT 5
- check_service_name_length() attempt to subtract with overflow HOT 5
- Updating service info when service is registered HOT 2
- A and AAAA mDNS records HOT 13
- Use `serde` for de/ser Txt Records HOT 4
- Failed to send to ... Resource temporarily unavailable (os error 11) HOT 2
- Received length loss HOT 21
- Issues with using a multicast IP for a service HOT 7
- Services published using python-zerconf or systemd-resolved are not resolved HOT 17
- Utility function to resolve mDNS hostnames HOT 7
- Add support for traffic reduction techniques from RFC6762, sec. 7
- Too verbose logging, even when logging is not enabled HOT 6
- question about interaction between record refresh and cache flush bit HOT 5
- Refactor functions warned by clippy::cognitive_complexity lint HOT 2
- Some weird caching behavior HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdns-sd.