Coder Social home page Coder Social logo

Comments (5)

JorTurFer avatar JorTurFer commented on May 29, 2024 2

Does this mean that we would need Datadog's APIService to use this feature? Also IIRC, there can only be one APIService in a cluster for the external.metrics.k8s.io, i.e., either Keda or Datadog.

I don't think so, that path is the path exposed by the server, so the idea is that you will have to install the DD Agent without registering the APIService. Then you can set the DD service endpoint in KEDA and KEDA will query the DD Agent without registering the APIService

from keda.

JorTurFer avatar JorTurFer commented on May 29, 2024

Hello @Adityashar

Thanks for reporting the issue. We are currently working on another solution via integrating the DD Agent as a source for querying the metrics: #5355

This will improve the behavior and relies on the agent the rate limiting management.

I'm not totally sure about adding a retry/delay system because it'll be released probably at the same time as the support for DD Agent and it'll handle the situation quite better, but I'm not against of it.
@zroubalik @tomkerkhove ?

from keda.

Adityashar avatar Adityashar commented on May 29, 2024

Thanks for reporting the issue. We are currently working on another solution via integrating the DD Agent as a source for querying the metrics: #5355
This will improve the behavior and relies on the agent the rate limiting management.

Thanks for this information @JorTurFer, looking forward to this feature!

from keda.

zroubalik avatar zroubalik commented on May 29, 2024

I agree with @JorTurFer

from keda.

Adityashar avatar Adityashar commented on May 29, 2024

@JorTurFer @zroubalik I was taking a look at @arapulido's draft code and saw this line:

return fmt.Sprintf("https://%s.%s.svc.cluster.local:%d/apis/external.metrics.k8s.io/v1beta1", datadogMetricsService, datadogNamespace, datadogMetricsServicePort)

Does this mean that we would need Datadog's APIService to use this feature? Also IIRC, there can only be one APIService in a cluster for the external.metrics.k8s.io, i.e., either Keda or Datadog.

from keda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.