Coder Social home page Coder Social logo

Comments (4)

JorTurFer avatar JorTurFer commented on June 5, 2024

Hello @Frezyy123
I think that having more control over the fallback, it's an interesting scenario to go deeper. I don't know how can we design this for being more flexible without being too complex. Do you have any idea/proposal about the design? (at high level)

from keda.

Frezyy123 avatar Frezyy123 commented on June 5, 2024

I assume that it should be configure like:

triggers:
    - type: cpu
      metricType: Utilization
      metadata:
        value: "50"
    - type: prometheus
      metadata:
         query: rate(my_beatuful_metric[1m])
         threshold: "3"
         skipFailing: true

Default behaviour is skipFailing: false (I guess skipFailing is better name), because we don't want breaking changes. So if you don't enable this option it will work the same as before
So controller just exclude failing metric and handle with cpu trigger only. When prometheus is reachable prometheus trigger works again.
I am not sure that it will be easy to realise, so I need a little bit more time for research

Fallback will work the same. If at least one of triggers without skipFailing: true fails, we set fallback values for hpa.

from keda.

JorTurFer avatar JorTurFer commented on June 5, 2024

@tomkerkhove @zroubalik WDYT?

About the proposal, I'd move the skipFailing property from metadata to the trigger spec directly

from keda.

zroubalik avatar zroubalik commented on June 5, 2024

Yes, I think this is doable, we should move it out of the metadata section. I don't like the name though :)

from keda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.