Comments (4)
Hello @Frezyy123
I think that having more control over the fallback, it's an interesting scenario to go deeper. I don't know how can we design this for being more flexible without being too complex. Do you have any idea/proposal about the design? (at high level)
from keda.
I assume that it should be configure like:
triggers:
- type: cpu
metricType: Utilization
metadata:
value: "50"
- type: prometheus
metadata:
query: rate(my_beatuful_metric[1m])
threshold: "3"
skipFailing: true
Default behaviour is skipFailing: false
(I guess skipFailing is better name), because we don't want breaking changes. So if you don't enable this option it will work the same as before
So controller just exclude failing metric and handle with cpu trigger only. When prometheus is reachable prometheus trigger works again.
I am not sure that it will be easy to realise, so I need a little bit more time for research
Fallback will work the same. If at least one of triggers without skipFailing: true
fails, we set fallback values for hpa.
from keda.
@tomkerkhove @zroubalik WDYT?
About the proposal, I'd move the skipFailing
property from metadata to the trigger spec directly
from keda.
Yes, I think this is doable, we should move it out of the metadata section. I don't like the name though :)
from keda.
Related Issues (20)
- Introduce authentication CRD that is not scoped to just triggers
- Colocating metrics provider along with the operator causes HPA delays if not configured properly HOT 9
- Reconciler crashes with ScaledObject postgres trigger and Vault for authenticationRef HOT 2
- Scalers for Azure Function Apps running under AKS are not really supported - although the documentation make it seem like they HOT 1
- Trying to integrate with Azure Managed Prometheus but getting Unauthorised issue HOT 5
- Enhance Security and Self-Service by Allowing Service Account Specification in Target Namespace for Workload Identity HOT 2
- Missing parameters 'rate' and 'count' for GCP Stackdriver Scaler alignment HOT 1
- Extend search scope of kubernetes workload scaler to all namespaces HOT 6
- KEDA Operator Not Exposing kube_horizontalpodautoscaler_status_current_replicas Metric HOT 2
- Restart of keda-operator causes ScaledJob object to be updated HOT 1
- Keda 2.13.1 Sysdig scan Vulnerabilities CVE-2024-27304 CVE-2024-24786 CVE-2024-28110 CVE-2024-28180 HOT 6
- Add Prometheus metrics related to ScaledObject readiness HOT 4
- ERROR scale_handler error getting scale decision {"scaledObject.Namespace": "elasticsearch", "scaledObject.Name": "dp-search-cluster-es-data-node", "scaler": "prometheusScaler", "error": "prometheus query api returned error. status: 403 response: {\"message\":\"Credential should be scoped to a valid region. HOT 1
- The replica count of target pods fluctuates when fallback is triggered in scaling-modifier HOT 11
- RabbitMQ HTTP Triggers ignore provided TLS Configuration HOT 2
- Multiple namespaces passed to WATCH_NAMESPACE
- Release: 2.14 HOT 2
- Kafka Transactions, commit markers and excludePersistentLag
- ScaledJob scaling calculation is different from ScaledObject scaling calculation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keda.