Comments (5)
When
triggers
is set with an empty array in ScaledObject, KEDA doesn't validate this empty value and will create a default HPA with a default 80% averageUtilization CPU resource. This can mislead users.
hmmm....that's interesting. From where this 80% of averageUtilization for CPU is coming in the HPA?
from keda.
When
triggers
is set with an empty array in ScaledObject, KEDA doesn't validate this empty value and will create a default HPA with a default 80% averageUtilization CPU resource. This can mislead users.hmmm....that's interesting. From where this 80% of averageUtilization for CPU is coming in the HPA?
It's K8s default behavior. When I create an HPA directly without metrics spec, k8s will create an HPA with 80% of averageUtilization for CPU resource.
HPA example:
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: test
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: sut
minReplicas: 1
maxReplicas: 10
from keda.
So that means HPA should not be defaulted to as a scaling option when triggers are empty in the KEDA's ScaledObject
from keda.
I think that we should validate it as part of admission hooks and also raise an error in the operator. Adding default value is quite weird as it's totally unrelated with the given triggers. This doesn't happen just with empty triggers
but also when there are some issues in the creation loop
from keda.
I agree, we should validate both on the Operator and validation webhook side. This is an ideal "good first issue " :)
from keda.
Related Issues (20)
- [ Azure] [Workload Identity] / Understanding Keda Controller Identity definintions vrs Workers Trigger Auth Identities HOT 4
- Provide scaler for Azure Event Grid Namespace Topics (Pull)
- SQS scaler processes float target queue length in a weird way, e.g. 6.5 would result in 5 on hpa object HOT 2
- Add metrics for gRPC requests between metrics-api-server and operator HOT 1
- KEDAScalerFailed with metrics-api error requesting metrics endpoint: Get "": context deadline exceeded (Client.Timeout exceeded while awaiting headers) HOT 8
- Release: v2.13.1 HOT 9
- Landing page is broken HOT 1
- keda gcp workload identity not working on keda-operator HOT 4
- Fallback oscillates between active and inactive when mixing Value and AverageValue metrics HOT 5
- Validate fallback configuration during admission process
- Supporting disabling admission rules based on resource annotation HOT 3
- Excessive calling of the DD API by KEDA HOT 7
- Prometheus scaler support for non-external metrics HOT 2
- Fallback doesn't work in case of RabbitMQ connection failure HOT 8
- Unpausing scaledobject broken HOT 4
- Unable to get external metric on GKE HOT 13
- Need Circuit breaker functionality for scaler HOT 1
- Issue with AWS MSK IAM using Apache Kafka scaler HOT 27
- Add support for Cassandra TLS auth HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keda.