kdjones / fuzzystring Goto Github PK

Hello,

Thanks for the package. It looks fantastic!

I haven't been working with this for more than 30 minutes, but I did import it into Unity, and the compiler immediately complained about the include line: using System.Threading.Tasks;

The full error was:
Assets/FuzzyString/ApproximatelyEquals.cs(5,24): error CS0234: The type or namespace name 'Tasks' does not exist in the namespace 'System.Threading'. Are you missing an assembly reference?

This is possibly because Unity is very strict about allowing any multithreading (though they're doing some great things with it via the new jobs system) and possibly because Unity uses an old version of C#.

Regardless, simply removing that include across all of the .cs files eliminated the error, and it seems from the lack of subsequent errors that maybe that include wasn't needed in the first place.

Just thought you might want to know in case other Unity users are eager to try FuzzyString.

Thanks,
-- Jeremy

Got fuzzystring from a nuget image (Microsoft nuget market-place) and it will not run. Instead; when control falls to the .DLL it seems to become cyclic or the handle is lost.

Thanks for creating this library. It would be helpful to know what license the library is released under: MIT? BSD?

See https://help.github.com/articles/adding-a-license-to-a-repository/.

Running the console program is extremely slow while comparing longer words separated with spaces.
The program has been running for over 20 minutes. I use a 2.80 GHz Intel Core i5 VPro processor which I think is quite fast enough to run that comparison within a second or two.

Is anybody else facing this issue?

"abab".RatcliffObershelpSimilarity("ababab");
it return 0.4 now.
the value should be 2 * ( 4 ) / ( 4 + 6 ) = 0.8

When I try to compare these two strings: "bla veg oil" and "bla vegetable oil" Normalized Levenshtein Distance algorithm never ends.

Does this work for Japanese and Chinese?

Tanimoto Coefficient doesn't work properly for the equal strings. For example if we use "kevin" and "kevin" it returns 0.2

instead of
FuzzyStringComparisonTolerance tolerance = FuzzyStringTolerance.Strong;
bool result = source.ApproximatelyEquals(target, options, tolerance);

it should be:
FuzzyStringComparisonTolerance tolerance = FuzzyStringComparisonTolerance.Strong;
bool result = source.ApproximatelyEquals(target, tolerance, options.ToArray());

It would be great to have an actual NuGet repository, with up-to-date code. There is an existing one, but it is obviously out-of-date (the project link points to codeplex).

Comparing the strings "united arab emirates" and "united arab emirates" (exactly the same string) results in a similarity of .6 which is definitely wrong. It also takes around 5 seconds to calculate. I would think that at the start of the method it should just check if the strings are equal and return 1 if it's true.