kclapper / tally-extract Goto Github PK

The output Excel file has formatting issues, especially with empty cells. When the program writes data to cells, each column is shrunk to the smallest possible width to fit the content. This means that if you write an empty string to one cell in a column that is otherwise empty, it shrinks the whole column to be super narrow. This can probably be resolved by writing void to the cell or by changing the automatic formatting, or both.

Github actions should be used to automate testing of new code pulled into the Main branch. After running all tests, the workflow should also compile the executable and attach it as a package that can be downloaded.

Once the program is finished, there should be an easy way to install it on both Windows and Linux that involves minimal configuration on the part of the user.

In a prior project written in Python, it was able to use pip to install the program from GitHub and make it available as a command line utility without calling the python interpreter explicitly. This level of installation ease is the goal. The target audience has python installed but not Racket. Apt may work for Linux installs, but it wouldn't be helpful for installing on Windows.

I'd like to avoid having installation instructions that have the user download the exe, put it somewhere, then make it executable, then add it to their PATH. If at all possible, I'd like the installation to be accomplished in one command.

Pretty clean code :)

• tally-extract/src/cell.rkt

  Line 11 in 610baef

  (if (empty? lines)

  
  Seems redundant with the call to map?

• tally-extract/src/read-file.rkt

  Line 39 in 610baef

  (define (remove-empty lists)

  
  Does filter do what you need here?

• tally-extract/src/tally.rkt

  Line 31 in 610baef

  (cons (section->tally (first sections) keff FMF)

  
  You can look into the concept of currying here

There are multiple MCNP output files that this program could parse. It's already capable of getting data from the primary ones that are needed, however, there are others that would be useful too. The program should add support for those file types.