kbss-cvut / s-forms-components Goto Github PK

Tested within unmerged pull-request #22.

• Layout still not working correctly for "Vlastnik"
• no comment icon on Cena
• no comment icon on "Ma provozovatele"
• no comment icon on Sekce s identifikatorem
• comment icon dialog is visualizing outside of the screen

It seems that migration to storybook was not successful. We lost somewhere original functionality. When I click to the components they are not smart in any of those two stories. (maybe some code related to component mappings was somewhere lost).

Moreover names of stories are not correct (I would rename it same way as in s-forms):
Default --> form1
AdvancedComponents -> Tourist Destination 1

QuestionCommentIcon should be implemented.

This is most-likely related to:
3494a4f

Which helped to the case it served, but for small amount of values it looks wird:

A/C:

• case from 3494a4f9befc3dcb7fc99ce515af5cdf40ecaf16should be solved without having to set minimal height (or could we use rather invisible margin to make space for autocomplete element ?)

Following url:
https://s-forms-components-kbss.netlify.app/?path=/story/sforms-smart-component--form-1

Wtihin storybook there should be Globals variable disableCustomComponents=true/false which turns of all custom components and show the form with "plain" s-forms layout.

The panel of such questions (e.g. "Oteviraci doba" question on the picture below) is divided into two parts and thus if we click on panel within right part of the screen nothing happens :

For TypeQuestionAnswer, question comment overlay is not displaying properly:

It should be possible to comment on show advanced question switch as can be seen here:

The issue with implementation is that "show advanced component" does not have reference to the component visualizing question related to "show advanced component switch". Implementation should be something like:

  _renderIcons() {
    const options = this.context.options;
    const {question} = this._getShowAdvancedQuestion();

    const showAdvancedQuestionComponent = //retrieve show advanced question component
    return Question.renderIcons(question, options, showAdvancedQuestionComponent.onCommentChange);
  }