The swiftpdfgenerator from kayoslab

swiftpdfgenerator's People

Contributors

Stargazers

Watchers

swiftpdfgenerator's Issues

UITextView.text always with default Values

The font and textColor Properties are not set when PdfFileGenerator.drawPageWithContext(page:UIView, context: CGContextRef) is called. The query always returns false and continues with default Values.

.ScaleAspectFit query could be more lucid

Very confusing implementation of the .ScaleAspectFit behaviour. This could be more lucid.

if (subview.isKindOfClass(UIImageView)) {
    if let image = imageView.image {
        if (imageView.contentMode == .ScaleAspectFit) {
            if (image.size.width > imageView.frame.size.width || image.size.height > imageView.frame.size.height) {
                if (image.size.width < image.size.height) {
                    // Landscape format
                    if (ratioWidth > imageView.frame.size.width) {
                        // Portrait does not fit into subview:UIImageView
                    } else {
                        // Portrait fits into subview:UIImageView
                    }
                } else {
                    // Portrait format
                    if (ratioHeight > imageView.frame.size.height) {
                        // Landscape does not fit into subview:UIImageView
                    } else {
                        // Landscape fits into subview:UIImageView
                    }
                }
            } else {
                // Image is smaller than subview:UIImageView
            }
        } else {
             // contentMode is not .ScaleAspectFit
        }
    }
}

Library simplified

Hey @kayoslab, I'd like you to take a look at my fork. I simplified the library folders and files to make it really easy for the devs to install and use the library as easy and quickly as possible.

What do you think?

Recommend Projects