kasimir123 / msdos-binary-ninja-view

A Binary Ninja BinaryView plugin for MSDOS.

MSDOS-Binary-Ninja-View

Author: Kasimir Schulz

Plugin to import MSDOS exe files into binary ninja.

Description:

Plugin to import MSDOS exe files into binary ninja.

Analyzes the code to find the offset to the data section and relocates data and code segments.

Minimum Version

This plugin requires the following minimum version of Binary Ninja:

• 2.4.3042

License

This plugin is released under an MIT license.

msdos-binary-ninja-view's Issues

Locks up BN when loading AGI interpreter

Tested the plugin with BN 3.2.3983-dev (latest dev) by downloading the first MSDOS binary Internet Archive gave me, AGI.EXE from this archive: https://archive.org/details/sierra-christmas-card-1986

The plugin locked up the entire UI in the init while loop, which turns out to be because the returned instruction length after a while is 0. This small patch makes it avoid and eternal loop, but the load will abort for other reasons shortly after:

diff --git a/__init__.py b/__init__.py
index 858756b..c80b17a 100644
--- a/__init__.py
+++ b/__init__.py
@@ -138,6 +138,9 @@ class MSDOSView(BinaryView):
             
             # add instruction size to start
             start += text[1]
+            if text[1] == 0:
+                print(start, "returned 0 lenght, aborting parsing")
+                break;
 
             # get all the instructions
             text = text[0]