karlhepler / angular-middleware Goto Github PK

One might want to set up a state to redirect to a sub-state using middleware.
Say, /docs always redirects to /docs/getting-started.

When a simple this.redirectTo('parent.child') middleware is written and called when routing to the parent state, it results in an infinite loop.

Example: (caution: crashes page)
https://plnkr.co/edit/syZdLJQ2I8ZomP7T9ndA?p=preview

In this example, there are state one with sub-states, one.one and one.two and state two. Presently, the only middleware used is one that simply calls this.next().

If one changes the middleware at the two lines commented with // Change to 'redirect' middleware to the redirect middleware, one expects that clicking the one and two links redirect to sub-state one.one. The two link performs as expected, but clicking the one link causes an infinite loop.

Hey!
Have you reached a verdict with Angular2 implementation of middlewares?

thanks

Love this new middleware. After coding a new NodeJS backend it got me thinking that really Angular needed middleware too ... and here it is 👍 . I'd propose it be part of Angular core.

What I think the documentation lacks is ...

• A demonstration of how to access the destination path or route. Often you want to apply an Aspect Oriented middleware rule that will include or exclude a pattern of route names or path names or parameter names. I'm not sure if params includes all of these so an example of how to do this would be very valuable.
• You often want to apply this to an abstract ui route so that a whole set of sub routes will have consistent middleware injected. This is really just a specialization of the pattern case but I think this very common case needs an example. It was what I went hunting for first when I looked over your documentation.

Adding these powerful examples should really help sell your concept.

When I include the module, all of my states stop rendering their templates. There are no errors in the console either.

angular.module('app.core', ['ngCookies', 'ui.router', 'ui.router.middleware']);

The repo on npm is out of date.

The redirectTo function in src/middleware.factory.js doesn't have params and options parameters. When install via npm the function has only route parameter available.

	/**
	 * Redirect to another route
	 *
	 * @returns {void}
	 */
	function redirectTo(route, params, options) {
		middleware.resolution.reject({
			type: "redirectTo",
			route: route,
			params: params,
			options: options
		});
	}

Hi,

I always get those error when setup the middleware. here is my code:

 $middlewareProvider.map({ 

            'check-token': ['Auth', (Auth) => {
                const request = this;
                Auth.get({ url: 'check-token' }, response => {
                    if (response) {
                        return request.next();
                    }
                });
            }]
        });

Hello,
Inside a middleware function, I tried to access 'this.route' and it gets undefined.
Tried this as saw in at the bottom of the documentation.

Thanks

Any plans to support ui-router 1.0 ? They've moved away from the $stateChange* events in favor of transition hooks: https://github.com/angular-ui/ui-router/releases/tag/1.0.0alpha0

I'm going to try and fork the repo and add support for it

In the ngRoute test file, the global middleware gets called twice in a row when initialized. Not sure why, but ui.router doesn't have this behavior. The ui.router configuration calls it once, as it should.