kan / coveralls-perl Goto Github PK

See https://travis-ci.org/tokuhirom/Minilla/jobs/6950859

t/01_basic.t .... 1/?     
    #   Failed test 'config'
    #   at t/01_basic.t line 30.
    #     Structures begin differing at:
    #          $got->{service_name} = 'travis-ci'
    #     $expected->{service_name} = 'coveralls-perl'
    # Looks like you failed 1 test of 1.
#   Failed test 'get_config local'
#   at t/01_basic.t line 31.
# Looks like you failed 1 test of 3.
t/01_basic.t .... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 

When I do a report with following .coveralls.yml:

service_name: travis-pro
repo_token: rZZqaGuPO8EpeiMlP66kE6yzpQNlLYuyw

https://github.com/binary-com/perl-FlyBy/blob/e7bee682cd2120d02aade6e1091c6ceb40ad8f6e/.coveralls.yml

It will report this error:
Couldn't find a repository matching this job.

If I update the report with this command by hand:
TRAVIS=false cover -report coveralls
or I set service_name as travis_ci, the result will be ok.

Devel::Cover supports comments to mark particular statements as uncoverable:

if ($x == 0) {
   return 0;
}
elsif ($x > 0) {
   return 1;
}
elsif ($x < 0) {
   return -1;
}
else {
   die("huh?); # uncoverable statement
}

Devel::Cover::Statement exposes this information via a method called uncoverable.

Would it be possible for Devel::Cover::Report::Coveralls to pass this information to coveralls.io? (According to the API reference, setting he coverage information for that line to null ought to do it.)

Getting this https://travis-ci.org/pjfl/p5-unexpected#L141

Can't locate object method "post_form" via package "HTTP::Tiny" at /home/travis/perl5/perlbrew/perls/5.14/lib/site_perl/5.14.4/Devel/Cover/Report/Coveralls.pm line 119.

which is new since it used to work

There are other version control systems too.

Would be nice if it could pick up things like committer name/email from environment variables or some other source.

i think repo_token is not required for Travis, so doing the check within TRAVIS is wrong.

Just copy what https://github.com/lemurheavy/coveralls-ruby/blob/master/lib/coveralls/configuration.rb does.

This module uses the v1 API that needs the repo token configured by some means, as shown in #33. However, looking at https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L51 it appears that there is another way for GH actions: to use Coveralls's webhook endpoint, which uses as its repo_token the GITHUB_TOKEN that, crucially, is already available. Are you open to a PR adding this capability, probably dispatched on a GITHUB_TOKEN env var?

This would mean eserte/graphviz-makefile#4 and graphviz-perl/Graph#16 wouldn't be needed (at least to get Coveralls working).

CIRCLE_BUILD_NUM is different for each job and therefore it is impossible for coveralls to group them together in parallel environment. However, I have no experience in using CircleCI so I may oversee the consequences of this change.

https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables

When run test on CircelCI.com, it will fail:

    #   Failed test 'config service_name'
    #   at t/01_basic.t line 45.
    #          got: 'circleci'
    #     expected: 'github-actions'

    #   Failed test 'config service_number'
    #   at t/01_basic.t line 46.
    #          got: '12387'
    #     expected: '123456789'
    # Looks like you failed 2 tests of 3.

#   Failed test 'get_config github'
#   at t/01_basic.t line 48.
    # No tests run!

#   Failed test 'No tests run for subtest "get_config github actions improved"'
#   at t/01_basic.t line 58.
required repo_token in .coveralls.yml, or launch via Travis at /home/git/.cpanm/work/1640820299.64935/Devel-Cover-Report-Coveralls-0.20/blib/lib/Devel/Cover/Report/Coveralls.pm line 131.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 4.

The mertadata for repository and issue tracker are wrong. They should be https not ssh. This is breaking the links on the CPAN::Meta page

For example this failure where Devel::Cover::Report::Coveralls crashes when trying to do something with the mostly-empty file blib/lib/Data/CROD/Array.pm.

外部サービスじゃなくgithubに置いてgithub.ioなURLで参照する。
0.04リリース時にやろう

As shown in lemurheavy/coveralls-public#1268 (comment), it would be really useful to document in this module how to achieve using it in GitHub Actions. Are you open to a PR adding such docs?

According to this comment coveralls added support for branch coverage metrics on top of line coverage.

Since Devel::Cover also measures branch coverage, it would be nice to allow this module to share that information with coveralls as well.

I might be able to send a pull request about that, but as of this moment I'm not familiar with the coveralls API, nor with this module's internals. Any further guidance would be appreciated. If someone else beats me to it, I can use that for learning purposes, so I'm fine with that too :)

Switching on verify_SSL seems unnecessary. Man-in-the-middle attacks are probably not a massive concern for pushing coverage data from Travis to Coveralls.

This seems to be fairly consistently preventing one of my repos from submitting any coverage reports. See for example:

• https://travis-ci.org/tobyink/p5-moosex-types-moreutils/jobs/37315735#L223

It would be helpful to add links to some example reports for Perl projects. That would help the user to quickly see the benefit it can get from enabling coveralls.io on his/her project.