kai4785 / takp Goto Github PK

The organic growth in action.c needs some cleanup. The whole "parseVerb" function is too long and isn't named right anymore.

There are a few things one must remember to do in order to read/write files across multiple platforms. Least of which is the O_BINARY flag that's only available on Windows, that we define as 0 on non-Windows platforms.

It can be useful to see magical damage by value. For instance, spell damage from a weapon proc separate from Damage Shields. Add an option to expand the magical damage report. Something like this:

Spell/DS(Total)            Soandso                47    6  0.13    726 121.00  15.45

Turns into this:

Spell/DS(32)               Soandso                47    3  0.13    726 121.00  15.45
Spell/DS(288)              Soandso                47    3  0.13    726 121.00  15.45

Where 32 damage is my Druid Damage Shield, and 288 is my Scepter of Destruction proc.

It's hard to see that the problem is that xdotool is missing. Make it easier to see, and help the user install xdotool.

$ ./takp_launcher.sh install
Unable to find config file, so I made one for you. Edit 'REDACTED' to set up your usernames and passwords.
Press Enter to continue

./takp_launcher.sh: line 317: xdotool: command not found
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  864k  100  864k    0     0  1937k      0 --:--:-- --:--:-- --:--:-- 1937k
system wine
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3278    0  3278    0     0    609      0 --:--:--  0:00:05 --:--:--   793

Handle crtl+c, so we can do cleanup on exit. Might be as simple as setting config->follow to false.

Logs do not reflect damage done by other player spells, with the exception of critical hits. So let's capture those crits.
Those logs look like this:
Soandso delivers a critical blast! (1699)

As a developer, debugging problems with reports if the report itself contained version and execution information. Add version strings and commandline arguments to the report output.

Add sorting options to the report. Like
--sort [name,dps,damage]
etc

Capture critical, cripple, and backstab damage, and add it to the report.

When --follow isn't specified, check to see if there's an unreported battle before exiting the program.

Finishing blows land for 32000+ damage, completely destroying your DPS numbers. We should handle these separately.
Soandso scores a Finishing Blow!!

It's usually interesting to report deaths that occur.

You gained experience!!
You gained raid experience!
You gain party experience!!

The Windows build does not error on warnings, and does not crank up the warning level. Maybe this is two issues, but could probably be handled in a single effort.
https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=vs-2017

The date string is currently parsed into an int for comparison sake. During reporting, it is preferable to see a human-readable format. So we need an int->datestring conversion routine.

When Ubuntu users haven't installed gawk, they get an obscure error:

awk: line 1: syntax error at or near ,

This happens in the gdown40 function that downloads the TAKP.zip from google drive.
Be nice, and help the user install gawk, and use gawk directly.

Paladin special melee attacks (like critical hits and crippling blows) look like this:
Soandso's holy blade cleanses his target!(2168)

More people will enjoy the tool better if it can be displayed in a GUI.
Consider multiple output formats:
command-line (current)
json
grpc
HTTP/Rest
HTML
GUI
Maybe this one?
https://github.com/vurtun/nuklear

More uniformly apply coding style for the following things.

Function names should be StructName_functionName
Struct members should be prefixed with m_
if/for/while should not be followed by a space, ie if(foo).
Open parenthesis should not be followed by a space, neither should a close parenthesis be preceded by a space, ie: for(int i = 0; i ++; i < 10)
Mathematical operators (=, +, -, >, <, ect) should have a single space character on either side.
4 space indentation

What else?

Log names are well-formatted as "eqlog_Name_loginse.txt". We can infer the --me value from the log file name, if --me was not specified.

Reports are grouped by Source right now. Sometimes it's a little easier to read if the report is grouped by target.