Coder Social home page Coder Social logo

Comments (2)

Kagamia avatar Kagamia commented on August 24, 2024

很想开一个review。。但在别人的repo中review不太礼貌,于是手动描述一下可见的问题:

  1. vs2022可以安装各种版本的.net framework devpack(除了已声明过时的4.62前的版本),无需强制升级到4.8。
  2. 所有的csproj文件的diff都没有被正确对比,这可能和git的autocrlf相关。
  3. EasyComparer.cs文件无法正确对比,甚至无法正常review到底改了什么。
  4. FrmPatcher.Designer.cs文件的改动中,出现了非本土化UI提示内容。
  5. CharaSimLoader.cs文件的改动中,存在未正确命名的变量Wz_Node wzNode,并且没有为前向兼容添加默认值或重载。
  6. StringLinker.cs文件的改动中,出现了无法理解的新增参数,但却没有使用过。同理所有的关联改动。
  7. Readme.md文件的改动中标注自己为contributor,似乎不太符合礼仪(个人感受)。

from wzcomparerr2.

HikariCalyx avatar HikariCalyx commented on August 24, 2024

了解,先放着看看,目前只是先私下做了一个修改build发现可行。

from wzcomparerr2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.