Comments (2)
很想开一个review。。但在别人的repo中review不太礼貌,于是手动描述一下可见的问题:
- vs2022可以安装各种版本的.net framework devpack(除了已声明过时的4.62前的版本),无需强制升级到4.8。
- 所有的
csproj
文件的diff都没有被正确对比,这可能和git的autocrlf
相关。 EasyComparer.cs
文件无法正确对比,甚至无法正常review到底改了什么。- 在
FrmPatcher.Designer.cs
文件的改动中,出现了非本土化UI提示内容。 - 在
CharaSimLoader.cs
文件的改动中,存在未正确命名的变量Wz_Node wzNode
,并且没有为前向兼容添加默认值或重载。 - 在
StringLinker.cs
文件的改动中,出现了无法理解的新增参数,但却没有使用过。同理所有的关联改动。 - 在
Readme.md
文件的改动中标注自己为contributor,似乎不太符合礼仪(个人感受)。
from wzcomparerr2.
了解,先放着看看,目前只是先私下做了一个修改build发现可行。
from wzcomparerr2.
Related Issues (20)
- 大佬可不可以提供一版Wzlib动态dll库 HOT 4
- 更新了0901之后,动画提取有点问题。 HOT 4
- 最新的 20230914 build 无法渲染 KMST 1.2.1161 的任何地图 HOT 4
- QuickView NPC Tooltip Render doesn't display NPCs with an outlinked Default thumbnail HOT 1
- MapRenderer: transparency not applied to background color (argb) selection HOT 9
- MapRender: png output on maps with transparent objects HOT 3
- KMS和KMST客户端比对后有部分新增图片未输出到对比档案 HOT 2
- 对比客户端的文件,感觉好像把每个文件都对比了一下 HOT 2
- Add CuttableCount display support in QuickView HOT 1
- 帧动画合成GIF的问题,每一帧的位置有偏差 HOT 5
- Spine does not account for phaseAtlas HOT 2
- All png files are not saved HOT 6
- MapRender 在高于 1920 x 1080 分辨率的显示器下,不会以 1920x1080 的分辨率窗口化 HOT 5
- 武器伤害上限加入单位 HOT 1
- 只会出现在 BUFF 中的技能 500061002 中的数值 #strX 无法正确被解析,能否将技能效果说明的部分隐藏 HOT 2
- 最新KMS客户端1.2.388中NPC功能文字颜色变了,希望maprender也能相应变色。 HOT 1
- KMST 1170 到 1171 更新文件有特别变化 HOT 5
- WzPatcher 希望加入跳过更新前校验检查功能 HOT 1
- KMST 1.2.1172 的活动地图渲染不正确 HOT 5
- 将林之灵的武器和副武器更改成“记忆长杖”以及“飞越”
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wzcomparerr2.