Medal style bug about wzcomparerr2

[Kagamia]

There' re two difference between these version:
1> low-level text renderer engine, GDI or GDI+
2> Graphics.TextRenderingHint, ClearType or AntiAlias

I've wrote a standalone program to compare them, here is it:

	var bmp = new Bitmap(500,300);
	var g = Graphics.FromImage(bmp);
	g.Clear(Color.DarkSlateGray);
	int y = 20;
	var font = new Font("Arial", 11f, FontStyle.Regular, GraphicsUnit.Pixel);
	var fmt = StringFormat.GenericTypographic.Clone() as StringFormat;
	
	string text = "Ambition 90, Willpower 90, Charm 90 EXP can be obtained once when equipped.";
	
	foreach(System.Drawing.Text.TextRenderingHint trh in Enum.GetValues(typeof(System.Drawing.Text.TextRenderingHint))) {
		g.TextRenderingHint = trh;
		g.DrawString(trh.ToString(), font, Brushes.White, 0, y);
		g.DrawString(text, font, Brushes.Orange, 20, y+12);
		TextRenderer.DrawText(g, text, font, new Point(20, y+24), Color.Orange);
		y+=36;
	}

In short words,

g.TextRenderingHint = System.Drawing.Text.TextRenderingHint.AntiAliasGridFit; 

makes texts more clear.
The advance of space character in GDI is a bit shorter than those in GDI+.

Font fallback in GDI+ looks better than GDI, that's why I use GDI+ mainly in CMS version.

GearGraphics.DrawString could be replaced with new version if there's no serious bugs. It support both GDI and GDI+ text rendering engine, but it measures with GDI+ and fixed-pitch fallback function.

So, how you merge these code is depend on what you like. :)

[Sunaries]

@Kagamia Using AntiAliasGridFit makes the font not similar to official GMS version. You can definitely see the font has changed even though it is Arial.

You can see the difference in the images I posted in this issue. Do you see the differences in the font style?
The first two images resemble the font style GMS uses.

However, a friend of mine came with a 'messy' (so he says) solution:

In GearTooltipRender2.cs line 1290 till 1294, the following is changed:

            if (!string.IsNullOrEmpty(medalName))
            {
                var brush = new SolidBrush(color);
                g.TextRenderingHint = System.Drawing.Text.TextRenderingHint.AntiAliasGridFit;
                TextRenderer.DrawText(g, medalName, font, new Point(130 - width / 2, picH -2), color);
                g.TextRenderingHint = System.Drawing.Text.TextRenderingHint.SystemDefault;
                brush.Dispose();

Is there a more robust way to do this? Because this code basically resets the TextRenderingHint back to system default after drawing the medalName text.

[Kagamia]

Yes you get the right way. 👍

Usually, alter and recovery statement is written like this:

var oldVal = g.TextRenderingHint;
g.TextRenderingHint = blablabla
// draw...
g.TextRenderingHint = oldVal;