k8snetworkplumbingwg / multi-networkpolicy Goto Github PK

Now that K8s v1.21+ supports endPort in NetworkPolicyPort field, should we also add it to multi-networkpolicy CRD?

From here: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.21/#networkpolicyport-v1-networking-k8s-io

endPortinteger | If set, indicates that the range of ports from port to endPort, inclusive, should be allowed by the policy. This field cannot be defined if the port field is not defined or if the port field is defined as a named (string) port. The endPort 
must be equal or greater than port. This feature is in Alpha state and should be enabled using the Feature Gate 
"NetworkPolicyEndPort".

@dougbtv @s1061123 any thoughts?

I got some feedback about the repository, to make current code separate from implementation and APIs for further implementation, as follows:

• k8snetworkplumbingwg/multi-networkpolicy (API and library)
• k8snetworkplumbingwg/multi-networkpolicy-iptables (iptable-based implementation)
• k8snetworkplumbingwg/multi-networkpolicy-foobar-some-awesome (another one)

+1 to the comment, so think about it. It would be discussed in next NPWG meeting.

Use case: User can add net-attach-def name in policy to specify which net-attach-def is the target

With this commit (1df4750) it looks like the Reflector used for multi-networkpolicy cannot get the policies with the following error message:

 reflector.go:178] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:125: Failed to list *v1beta1.MultiNetworkPolicy: the server could not find the requested resource (get multi-networkpolicies.k8s.cni.cncf.io)

Reverting the commit fixes the problem.