Coder Social home page Coder Social logo

Comments (3)

jyggen avatar jyggen commented on September 26, 2024

I thought about this back when I implemented support for the If-Modified-Since and Last-Modified headers and the conclusion back then was to not cache requests without headers at all since I didn't really want the library to make assumptions/behave unexpectedly.

The data from the classes/races endpoints should preferably be stored in a database and only be updated once per expansion, but if people want to waste they rate limits on that data then I think we should let them. If Blizzard wanted us to cache these requests they would've added a Last-Modified header to the responses :)

from bnet.

morloderex avatar morloderex commented on September 26, 2024

True, but neverless i think we should allow for setting a custom cache time just for the optionalism it creates.

from bnet.

jyggen avatar jyggen commented on September 26, 2024

Closing this since it's now out-of-scope for this library.

from bnet.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.