Comments (3)
I thought about this back when I implemented support for the If-Modified-Since
and Last-Modified
headers and the conclusion back then was to not cache requests without headers at all since I didn't really want the library to make assumptions/behave unexpectedly.
The data from the classes/races endpoints should preferably be stored in a database and only be updated once per expansion, but if people want to waste they rate limits on that data then I think we should let them. If Blizzard wanted us to cache these requests they would've added a Last-Modified
header to the responses :)
from bnet.
True, but neverless i think we should allow for setting a custom cache time just for the optionalism it creates.
from bnet.
Closing this since it's now out-of-scope for this library.
from bnet.
Related Issues (15)
- OAuth set configuration? HOT 3
- Does not handle invalid API Key gracefully HOT 1
- Suggestions HOT 10
- Guild entity members (Convert to character entities if member field is set) HOT 2
- Laravel HOT 3
- Make PSR-6 implementation optional HOT 5
- API Wrapper occasionally hanging while communicating with Blizzard HOT 4
- Bump minimum PHP version to 7.0 HOT 4
- Invalid conversion of WoW guild members to character entities HOT 1
- CodeIgniter HOT 2
- Still in progress? HOT 4
- Migrate to develop.battle.net
- implement the 6.0.3 changes to the bnet package HOT 3
- upgrade to support Oauth2 client? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bnet.