Suggestions about bnet

[jyggen]

Hi! .. and sorry for the late reply :)

I need to think about class and race functions, it might be out of scope for this library.

As for /wow/mount it would probably go under src/Warcraft/Mounts.

[garretthunter]

@morloderex are you thinking something more than races() in Pwnraid\Bnet\Warcraft\Characters?

[morloderex]

@jyggen Should i make a PR for this or will you implement this yourself?

@garretthunter I'm thinking of mapping the entity returned from for example the the character method, so blizzards races integers could look like something like this on the entity object.

//sample data directly from the entity object returned from blizzards API before the mapping

"lastModified": 1448960961000,
    "name": "Morloderex",
    "realm": "Frostwhisper",
    "battlegroup": "Cruelty / Crueldad",
    "class": 2,
    "race": 10,
    "gender": 0,
    "level": 100,
    "achievementPoints": 5750,
    "thumbnail": "internal-record-3657/240/109304304-avatar.jpg",
    "calcClass": "b",
    "faction": 1,
    "totalHonorableKills": 5095

Suggested mapping example:

 "lastModified": 1448960961000,
    "name": "Morloderex",
    "realm": "Frostwhisper",
    "battlegroup": "Cruelty / Crueldad",
    "class": "Paladin",
    "race": "Blood Elf",
    "gender": "Male",
    "level": 100,
    "achievementPoints": 5750,
    "thumbnail": "internal-record-3657/240/109304304-avatar.jpg",
    "calcClass": "b",
    "faction": 1,
    "totalHonorableKills": 5095

This should be able by just mapping over an array or by making a new request to blizzard via a method and then filter the necessary data.

[garretthunter]

I see, thank you for the explanation @morloderex. Because race/class data changes so rarely I am planning to cache it locally and write a library to do that transformation. I figured it would help my performance to minimize the number of calls I make to blizz api. As you noted, I will have to constantly translate all the key valuses to human friendly text.

[morloderex]

@garretthunter
Exactly my point you got there it's meant to
reduce the number of requests maid to the api.

I would rather do that on the entity object if possible. 😁

[jyggen]

@morloderex Feel free to PR the mounts endpoint.

[jyggen]

@garretthunter @morloderex How about something like #14?

[garretthunter]

@jyggen yes, I like how the class / race text is now included in the character. thanks!

[morloderex]

@jyggen that's exactly what i had in mind.

I aplicatie that you took your time to write it out :)

[jyggen]

Cool, I'll merge it and close this issue then. Feel free to create a PR for mounts.

Thanks!