jyash97 / cra-to-vite

Hi there 👋

cra-to-vite's Issues

deprecated vite-react-jsx plugin in vite.config.js

Thanks for this tool, but there is one issue. It creates vite.config.js with deprecated plugin vite-react-jsx, it needs to be replaced with @vitejs/plugin-react instead. because it causes some hot module replacement problems in vite@latest.
I think vite.config.js should look like this :

see warning in their github repo :
https://github.com/alloc/vite-react-jsx

Is there a reason why we can not use the esbuild option to specify loaded jsx for .js files?

First of all great work on this plugin. This is one of the problems I faced too while converting an existing app to vite, so thank you so much for building this.

I have one question though and this is after I went through the esbuild and vite docs.
https://esbuild.github.io/content-types/#jsx
https://vitejs.dev/config/#esbuild

So the docs for esbuild say that we can pass an option saying that the loader to be used for js files should be jsx.

esbuild app.js --bundle --loader:.js=jsx

Did you find any issues with using this option while converting an existing app to vite?

Some files can't be converted to ".jsx"

Hi, first of all, this script/tool is awesome. I really appreciate what you've done. Unfortunately, I faced some issues as described below

So any idea what some files can't be converted to ".jsx"? Thanks a million :)