jweir / colorwheel Goto Github PK

On Raphael 2.1.3 the center square doesn't change its color (it does change on Raphael 2.1.2).

Pure white (#FFFFFF) can not be reached from the color picker when using Raphael 1.5.2

I noticed that if you feed it a color via

cw.color('#ff0000')

it doesn't update the input field associated with it, and internally it doens't change the color.

if you then do a

cw.color()

it will still read whatever the color was prior to changing it. The hue ring shows the correct color, but it doesn't register internally.

Noticed an issue where using .input() to hook it to a text field makes the color wheel spawn plenty of errors in Chrome.

Error, as taken from console: "Uncaught TypeError: object is not a function".

Issue is that the input() function resets "change_callback = null;", whereas run_onchange_event() does a stricter type evaluation for "!== undefined".

Making a less strict check, such as "if(change_callback)" instead will allow for both of these, but maybe the real fix would be to remove the modification inside of input()? I did not see the reason behind the reset.

Hello, when using this colorwheel with the most recent Raphael the color ring is constant white. Tested with Raphael 1.5.2.

Adam

Now that browsers have canvas or SVG support, Raphael is not really required.

There is a way to change the color whitout linking an input?

I have this error

Uncaught TypeError: Cannot read property 'x' of undefined

How to solve it

The readme points to http://jweir.github.com/colorhweel . This page 404's

It's actually a bug from raphaeljs's "hsb2rgb" function itself. To replicate, all you need to do is provide the values "000001", "000100" or "010000" and instead of giving you an almost-black color, it gives you the equivalent of "00f", "0f0" or "f00".

I'm personally modifying the code to use another library instead of raphaeljs's hsb2rgb (https://github.com/bgrins/TinyColor) but this is just fyi. Will you be fixing this?

We are running colorwheel in a page with css zoom applied, and the mouse and touch events do not work as needed. This may be because the coordinates of the touches and clicks are not taking the zoom factor into account, so the color wheel is not working for our project.

Steps to reproduce:

1. Go to http://jweir.github.io/colorwheel
2. In Developer Tools, Elements, choose the root element HTML
3. Set style zoom: 0.5
4. The color wheel is not operable

The default implementation doesnt seem to allow dragging the color pickers along the interface.
Any way to achieve that?

Hello,

I cannot get the colorwheel working properly using getDocumentById(). I get errors about cx and cy.

my test is here

Any idea?

I use the last colowheel version with raphael 2.1.4 because of canvas.safari() issue
but onchange() doesn't work !?!

http://jsfiddle.net/ndgAlainB/rm92syeq/28/

Hi,
I was testing and I saw that the colorwheel is turned grey in IE9 (fine in 7 and 8)
when I move the picker, the little square chenges correctly and the textbox changes accordingly
but the circle itself is grey
see here
http://imageshack.us/photo/my-images/594/capturelcy.png/

compatibily view has it also
quircksmode looks correct

IE 9.0.8112.1621
WIN7 x64 SP1

colorwheel creation breaks on canvas.safari() in the create function as Raphael == 2.2.0.

Will PR to fix Raphael's version in bower.

If you link an input field to the colorwheel and you input #aabbcc, the value will roundtrip as #aabacc

This is fixed by DmitryBaranovskiy/raphael#977

In IE, the stroke:none value for the segments causes it to draw borders with default black color. This prevents uniform look and feel, this is cured by changing

Line 261 to
n.attr({stroke:"hsb("+d_(1/k)+", 1, 0.85)",fill:"hsb("+d_(1/k)+", 1, 0.85)"})

now the stroke is not seen and same look and feel is achieved in IE also