Coder Social home page Coder Social logo

fbnix's People

Contributors

dependabot[bot] avatar justinkalland avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

fbnix's Issues

Implement standard-version

Implementing standard-version will help automate releasing new versions of the package (as well as automatic changelogs).

  • Add standard-version package
  • Setup release and pre-release scripts (see jwt-guard for example)
  • Add details in contributing documentation

Blocked by #2

Improve testing logic with image URLs

Tests are fragile right now because they are checking image URLs to be exact matches of when the test was created. Facebook changes the URLs often.

Example:

'https://scontent-frx5-1.xx.fbcdn.net/v/t1.0-9/45494942_774372489567165_5172707475698221056_n.jpg?_nc_cat=105&_nc_sid=8024bb&_nc_oc=AQnQFJWFOIm4IypMosy8AOPVzJPjPLW6CKIgXUqCHeCNVZCtOeeOCqB5RXRZDqOtaBc&_nc_ht=scontent-frx5-1.xx&oh=c31f0278b77d45b8e7e6a9409688a949&oe=5F0CD0D2',

Some possible solutions:

  • Use regular expressions to check that the URL meets criteria
  • Actually try and load the images in a puppeteer window to see if the URL is good
  • Combination of the two

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.