Coder Social home page Coder Social logo

justarrived / just-match-frontend Goto Github PK

View Code? Open in Web Editor NEW
2.0 14.0 9.0 8.56 MB

[ABANDONED] Frontend for JustMatch API

Home Page: https://antrop.invisionapp.com/share/FA62UU66R

License: MIT License

JavaScript 62.00% HTML 24.87% CSS 12.87% Shell 0.22% Ruby 0.03%
deprecated transifex translation justmatch angularjs abandoned justmatch-client

just-match-frontend's Issues

Missing "Find jobs" link in menu for regular users

Description

As a user there is no way to navigate to the "Find jobs" view, its only possible if you go back to the start page and from there click on "New assignments > Show all".

Severity: Bad UX

URL: Every page

Role: User

How to recreate it

  1. Login as a user

Screenshot

screen shot 2016-05-07 at 16 51 38

No way to add payment details

Description

The view where a user can add there payment details doesn't send any requests to the API. (FYI there is a field frilans_finans_payment_details returned for users that is true only if the user has already filled out those fields (so the user doesn't have to fill them in every time).

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/arriver/job/:id

Role: User

How to recreate it

  1. Login in as regular user
  2. Click on a job where the user is accepted for the job, but has not yet confirmed it
  3. Accept the job
  4. Fill out the payment details
  5. Click continue

Expected outcome: Payment details sent to the API

Screenshot

screen shot 2016-05-07 at 21 47 38

Email validation rejects valid email addresses

Description

Even though the email address is valid the frontend marks it as invalid and its not possible to submit the user registration form.

Severity: Can't complete action

URL

http://justarrived.dev-machine.com/#/user/register

Error message: "Du måste ange en giltig email"

Role: Not logged in

How to recreate it

  1. Goto register user page
  2. Fill in the email address [email protected]
  3. The frontend marks it as an invalid email even though its not

Expected outcome

No validation error and possible to submit form.

System: OSX

Browser (check what browser am I running): Chrome

Screenshot

screen shot 2016-05-04 at 09 10 06

When a user applies the wrong copy is shown

Description

When a user applies for a job the feedback messages states (paraphrased):

An account has been created and you've applied for your first assignment
When your email is confirmed the assignment will be created

The information is not only wrong but also a mix between applying for a job (regular user) and creating one (company user).

Severity: Wrong information / feedback

URL: http://justarrived.dev-machine.com/#/job/accept

Role: User

How to recreate it

  1. Login in as regular user
  2. Goto a job page
  3. Apply or job

Expected outcome: A message stating that the user has applied for a job and that they'll receive an email/notification if they're accepted by the job creator.

Screenshot

screen shot 2016-05-07 at 20 23 33

Hard coded comments count on company job page

Description

On the company job page the number of comments is hardcoded to always be "Två kommentarer", so it shows the wrong information and the translation is missing.

Severity: Incorrect information

URL: http://justarrived.dev-machine.com/#/company/job/:id

Role: Company user

How to recreate it

  1. Create a job
  2. Goto to "My assignment"
  3. Click on a created job

Expected outcome: The correct number of comments are shown with the correct locale.

Screenshot

screen shot 2016-05-07 at 20 16 50

Apply for job button is shown even though the user has already applied

Description

Even though the user has applied for a job the apply-button (that currently has the wrong text..) is shown. Also if the user clicks the button there is no visible error message even though the backend returns a 422 status that the user has already applied to the job.. Meaning that the user will not be taken anywhere and it will look like the button just doesn't work..

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/jobs/:id

Error message: No error message (thats the problem...)

Role: Company user / user / Not logged in

How to recreate it

  1. Goto ...
  2. Click ...
    3.

Expected outcome

Either no button should be shown or an error message should be displayed to the user, stating that they've already applied for it..

Screenshot

screen shot 2016-05-07 at 18 24 12

"My assignments" page for company user broken

Description

There is an exception thrown on the page "My assignments" for a logged in company users. I'm not sure how/if it brakes other features on that page. The culprit seems to be that the code assumes that there always are a user image, which is not the case.

The line that causes the exception is CompanyJobCtrl.js:59.

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/jobs

Role: Company user

How to recreate it

  1. Login in as a company user
  2. Goto a job where a user has applied that has no profile image

Screenshot

screen shot 2016-05-07 at 22 13 42

Add Google Maps API key

We must add a valid Google Maps API key to the frontend otherwise Google will throttle us a lot more and we risk that our quota is existed, thus breaking all maps within the app.

The API key must be created/provided by @FivelFred and it should limit the domains it can be used on to dev-machine.com and *.justarrived.se. @FivelFred feel free to ask for help creating the key.

After the key is created we should add it to a config file, so its easy to update.

Company user can't rate user

Description

Currently it doesn't seem possible to rate a user even though an invoice has been created

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/jobs

Error message: None

Role: Company user

How to recreate it

  1. Create job
  2. User apply for job
  3. Company user accept user
  4. User confirm acceptance
  5. Company user create invoice
  6. Company user go to http://justarrived.dev-machine.com/#/company/jobs
  7. Try to click on the "stars" to give a rating
  8. Nothing happens..

Expected outcome: Company user rates the user

Screenshot

screen shot 2016-05-07 at 18 51 29

User register server validation errors are not displayed next to the field

Description

Server validation errors are displayed beneath the submit-button, rather than next to the field that has the error making it very unclear what went wrong (see screenshot). This issue concerns the validation "email has already been taken", but it seems like its a general problem..

Severity: Broken styling / Confusing

URL: http://justarrived.dev-machine.com/#/user/register

Error message: "has already been taken"

Role: Not logged in

How to recreate it

  1. Goto register new user
  2. Fill in valid details, but with an email address that already exists in the system
  3. Submit the form

Expected outcome: Validation error displayed directly beneath the field that has the validation error.

Screenshot

screen shot 2016-05-07 at 15 37 49

Unimplemented feature Translate from X in "Send message" view on chose candidate page

Description

Unimplemented feature Translate from X in "Send message" view on chose candidate page.
Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/job/107/candidate/286

Role: Company user

How to recreate it

  1. Login as company user
  2. Click on a job that has candidates
  3. Click on "Chose candidate"
  4. Click on a candidate in the list
  5. Click on "Send message"
  6. Click on "Translate from X"

Expected outcome: The chat is translated to the current users chosen locale.

Screenshot

screen shot 2016-05-07 at 21 08 11

Unimplemented feature "Send message" on chose candidate page

Description

Unimplemented feature "Send message" on chose candidate page. When clicking "Send message" a hard coded chat is displayed and its not possible to send a message; no request is sent to the API and nothing happens visually.

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/job/107/candidate/286

Role: Company user

How to recreate it

  1. Login as company user
  2. Click on a job that has candidates
  3. Click on "Chose candidate"
  4. Click on a candidate in the list
  5. Click on "Send message"

Expected outcome: The real chat is displayed.

Screenshot

screen shot 2016-05-07 at 21 08 11

Create comment is "spammable"

Description

The job comment field is "spammable" in the sense that if the user fills in a comment and then hits ENTER a few times in a row, the comment is submitted to the API multiple times.. Instead the field should be cleared instantly while the comment is being submitted to the API.

Severity: Enhancement

URL: http://justarrived.dev-machine.com/#/jobs/:id

Role: User

How to recreate it

  1. Login as any user
  2. Goto to a job page
  3. Fill in a comment
  4. Hit the ENTER-key a few times in a row

Expected outcome: Only one comment is submitted

Screenshot

screen shot 2016-05-07 at 17 03 45

Company user can't create invoice

Description

Currently there seems to be now way for a company user to create an invoice / confirm the users performance.

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/jobs

Role: Company user

How to recreate it

  1. Login as a company
  2. Make sure there is a user that has been hired and the job date is in the passed
  3. Goto "My assignments"

Expected outcome: The job is listed and it should be possible to create an invoice.

Screenshot

screen shot 2016-05-07 at 22 26 07

Wrong acceptance time displayed on "hire" confirmation page

Description

The confirm page states that the user has 12 hours to accept the job, which is in correct, it should be 18 hours.

Severity: Wrong information

URL: http://justarrived.dev-machine.com/#/company/job/107/candidate/286

Role: Company user

How to recreate it

  1. Login as company user
  2. Click on a job that has candidates
  3. Click on "Chose candidate"
  4. Click on a candidate in the list
  5. Click on "Hire"/"Anlita"

Expected outcome: The correct information is displayed.

Screenshot

screen shot 2016-05-07 at 21 17 12

Unimplemented feature "References" on chose candidate page

Description

Unimplemented feature "References" on chose candidate page. When clicking "References" nothing is displayed and no request is made to the API

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/company/job/107/candidate/286

Role: Company user

How to recreate it

  1. Login as company user
  2. Click on a job that has candidates
  3. Click on "Chose candidate"
  4. Click on a candidate in the list
  5. Click on "References"

Expected outcome: The users ratings and comments are displayed.

Screenshot

screen shot 2016-05-07 at 21 12 53

Unnecessary loading of Google Maps library

Currently the Google Maps JavaScript library is imported on each and every page, instead of just the pages that its used. Since Google Maps is only used on a few pages its quite unnecessary to load it on every page.

Misleading button title for hired user on job show page

Description

Currently the button that allows a hired user to indicate that they've performed only says "Ja", making it impossible to know what the button does.

Severity: Wrong/misleading copy

URL: http://justarrived.dev-machine.com/#/arriver/job/107

Role: Hired user

How to recreate it

  1. Login as a regular user
  2. Goto a job where the user has been hired and the job date is in the past

Expected outcome: The button says something a long the lines of "Confirm performance of job"

Screenshot

screen shot 2016-05-07 at 21 54 43

Can't continue from create user profile view

Description

Can't continue from the create profile view even though successful PATCH requests are sent and returned with a 200 ok status, the frontend does not "redirect" the user to the next view.

Severity: Can't complete action

URL: http://justarrived.dev-machine.com/#/user

Error message: None

Role: User

How to recreate it

  1. Register a new user
  2. Fill in required fields on "Create profile" page
  3. Click "Fortsätt"

Expected outcome: Redirected to the next page.

System: OSX

Browser (check what browser you're running at https://whatbrowser.org): Chrome

Screenshot

screen shot 2016-05-07 at 16 18 08

Frontend doesn't send X-API-LOCALE header even though the user has changed locale

Description

Even though a user has explicitly changed locale the frontend doesn't send the X-API-LOCALE header to the backend, causing the backend to always return the users default locale rather than their current setting.

Severity: Wrong translation

URL: *

How to recreate it

  1. Create a user with the primary language Swedish
  2. Change the locale to English
  3. The header X-API-LOCALE is not sent to the backend

Expected outcome: The frontend sends the header to the API

Screenshot

screen shot 2016-05-07 at 18 24 12

Unnecessary loading of languages on create user profile

Description

Every time the "LANGUAGE SKILLS*" field is clicked /api/v1/languages?filter[name]= is fetched causing unnecessary wait for the user and extra load on the server. Should only be requested if the user types something

Severity: Enhancement

URL: http://justarrived.dev-machine.com/#/user

Error message: None

Role: User

How to recreate it

  1. Register a new user
  2. On the next page click the "Language skill" field
  3. The frontend requests /api/v1/languages?filter[name]=

Expected outcome: Frontend only requests when the user has typed something.

Screenshot

screen shot 2016-05-07 at 16 14 29

Missing "close" icon in chose language menu

Description

There is no close icon in the chose language menu, the only way to close it is to click a language.

Severity: Bad UX

URL: *

How to recreate it

  1. Click the locale/language icon in the navbar

Expected outcome

A "close" icon is shown in the top right corner (just like in the "Menu")

Screenshot

screen shot 2016-05-07 at 20 29 25

Hard coded user chat on company job page

Description

On the company job page the number of comments is hardcoded to always be "Två kommentarer", so it shows the wrong information and the translation is missing.

Severity: Incorrect information

URL: http://justarrived.dev-machine.com/#/company/job/:id

Role: Company user

How to recreate it

  1. Create a job
  2. Goto to "My assignment"
  3. Click on a created job

Expected outcome: The correct chat is shown (if any)

Screenshot

screen shot 2016-05-07 at 20 16 50

Google Maps doesn't center correctly on jobs listing page

Description

On the jobs listings page the map doesn't center around the job locations correctly. Even though there are jobs in both in Denmark and Stockholm (on staging) the map always centers around the job in Denmark.

Severity: Broken styling

URL: http://justarrived.dev-machine.com/#/jobs

How to recreate it

  1. Navigate to the jobs listing page

Expected outcome

The maps centers around all locations, if locations are far apart it should zoom out and show them all..

Screenshot

screen shot 2016-05-07 at 18 38 06

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.