Comments (4)
Thank you a lot for reporting this issue, I've managed to add unit test verifying that what you stated above is correct, and ASF behaviour was wrong.
When excessive amount of "missing amounts", so items in the set was missing on our side, there was a possibility for our logic to classify a good trade as bad one, because we didn't fill in enough holes, as the subtraction in the condition was calculated on each loop rather than once initially.
Since this could only worsen the neutrality score, but never improve it (as the amounts were sorted ascending), there was no abusive possibility due to that, only ignoring otherwise valid trades classifying them as worse than they were in reality.
Fixed in V6.0.3.1 which I'll release in a second.
from archisteamfarm.
Thank you! Have a nice week!
from archisteamfarm.
No need, I've confirmed it with unit test on our side. I have no clue what's wrong yet, but it's enough to move the issue forward.
from archisteamfarm.
I will try again without custom plugins later, but I don't expect a change of behavior.
from archisteamfarm.
Related Issues (20)
- help with !play command
- OnPersonaState() System.InvalidOperationException: descriptions is empty! HOT 12
- DuplicateRequest Exception from ArchiHandler.GetMyInventoryAsync HOT 7
- Investigate regression in items matcher
- .NET 8.0.3 regression makes ASF to crash on x64 processors with no SSE4.2 support HOT 5
- ArchiSteamFarm.OfficialPlugins.Monitoring crashing ASF HOT 1
- Evaluate possibility of rewriting our XPath queries to CSS selectors
- [Suggestion] Check first badge page before CheckOccupationStatus() HOT 7
- Incorrect default value for ShutdownIfPossible HOT 2
- multiple commands HOT 2
- [Plugin API] allow plugins read-only access to ParseTradeResult.EResult HOT 1
- Select a specific status to execute a command on it. HOT 3
- Inquiring about the functionality of GamesPlayedWhileIdle. HOT 1
- Make --system-required work on Linux?
- Not farming dota 2 cards HOT 1
- Not recognizing config file HOT 3
- Will ASF consider displaying the Steam Deck online? HOT 7
- Resolve CA1863 by using emitted methods HOT 1
- Add timer to `!play` command HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from archisteamfarm.