just-work / django-denormalized Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 3.0 93 KB

Utils for maintaining denormalized aggregates for Django models

Python 100.00%

django-denormalized's People

Contributors

Stargazers

Watchers

Forkers

tumb1er ttys15 mikelarg

django-denormalized's Issues

Initial Update

The bot created this issue to inform you that pyup.io has been set up on this repo.
Once you have closed it, the bot will open pull requests for updates as soon as they are available.

Incorrect usage with two or more DFK

If same model has two or more DenormalizedForeignKey, only first one counted correctly, because of initial state reset multiple times in post_save signal handlers.

Max/Min support

Add support for Max/Min denormalization.

Change CI badge to github actions

Crash on cascade delete

KeyError: 'episode_season'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/tumbler/PycharmProjects/acms/src/tools/tests.py", line 218, in assertValidationPassed
    type(obj).objects.filter(pk=obj.pk).delete()
  File "/data/acms/virtualenv/lib/python3.6/site-packages/django/db/models/query.py", line 663, in delete
    deleted, _rows_count = collector.delete()
  File "/data/acms/virtualenv/lib/python3.6/site-packages/django/db/models/deletion.py", line 306, in delete
    sender=model, instance=obj, using=self.using
  File "/data/acms/virtualenv/lib/python3.6/site-packages/django/dispatch/dispatcher.py", line 175, in send
    for receiver in self._live_receivers(sender)
  File "/data/acms/virtualenv/lib/python3.6/site-packages/django/dispatch/dispatcher.py", line 175, in <listcomp>
    for receiver in self._live_receivers(sender)
  File "/data/acms/virtualenv/lib/python3.6/site-packages/denormalized/models.py", line 84, in _track_changes
    foreign_objects = tracker.track_changes(instance, created, deleted)
  File "/data/acms/virtualenv/lib/python3.6/site-packages/denormalized/tracker.py", line 35, in track_changes
    old_foreign_object = getattr(old_instance, self.foreign_key)

full aggregate counts excluded objects

When generating full aggregate for Min/Max, queryset is not filtered against self.query in tracker.

Need public interface

for denormalized field value update, needed to extend existing method with cacheops invalidation
for caching initial object version, needed to reset python object state in tests

Sometimes there is need to perform denormalization for all objects in db table (migrations, recompute after bugfixes).
Need denormalize(queryset, ...) method to perform such bulk denormalization.
This could be done with [update from select with aggregates] (https://docs.djangoproject.com/en/2.1/ref/models/expressions/#using-aggregates-within-a-subquery-expression).

Read the docs

Since public interface for this app appears to have more than single class definition, documentation should be written and published to RTD.

Tests are failing in CI

refresh_from_db should update initial version

When using refresh_from_db(), initial version should be updated, respecting fields arg.