Can't connect to WS after launching separate headless chrome instance about galata

[dharmaquark]

@mbektas any local workaround you could suggest? Or could we help in pushing a patch upstream to address?

[mbektas]

Hi @dharmaquark and @bsyouness! I have been looking into this issue. I have a solution that seems to work for remote connected and new browser instances for chromium. Created this PR (#66) with my changes, please test it well and push your additional changes to that branch. I didn't get chance to test thoroughly and with other browser types.

[bsyouness]

Awesome! I will test soon and keep you posted. Thank you so much @mbektas !!

[legendb317]

Hi! @mbektas. Yeah I will do some testing and get back to you. Thank you!

[legendb317]

Hi @mbektas. I have tested with chrome and edge and everything works as expected. However, I was not able to successfully test firefox. The process hangs here:

galata/packages/galata/jest-setup.js

Line 76 in 610f1ba

browser = await pwBrowser.connectOverCDP({

Upon further investigation, it seems that firefox has an issue with setting up a remote debugging port. To reproduce the issue, I set up an alias for firefox using alias firefox=/Applications/Firefox.app/Contents/MacOS/firefox. Next, I enabled add-on debugging toolboxes and remote debugging in the browser. Finally, I ran firefox --remote-debugging-port which outputs a ws link that DevTools is listening on. When placing this link into a browser, it does not load. I suspect this to be the reason why the pwBrowser.connectOverCDP never resolves.

There seems to be an issue with firefox rather than Galata. Does it make sense to open a separate issue to investigate this further so that we do not hold up the fix with chromium browsers?

[bsyouness]

+1
I also tried to run firefox --remote-debugging-port and saw the same symptoms as Legend. I think it makes sense to patch this in to get something working and tackle the Firefox issue separately. I would also report the issue to Mozilla so they can assist.

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[mbektas]

@bsyouness I am able to reproduce the issue. Looks like we need to handle remote connection to chromium browser specially.

[legendb317]

Hi @mbektas. We have tested the PR with chromium and the process no longer hangs. Thank you for fixing this issue.

[mbektas]

hi @legendb317 thanks! We also need to test with Firefox (--browser-type firefox) and Microsoft Edge (--browser-type chromium --browser-path /path/to/edge") before merging. Would you have some time to do that testing?