junzis / openap-top Goto Github PK

I have a problem in getting OpenAp to work.
I installed everything correctly as mentioned in the Readme. No errors reported.
Than I activated the environment via the terminal.

After that I switched to Jupyter Notebook and wanted to give the instructions step by step, beginning with "import openap.top as otop".

But I can't import anything?

Do I have a mistake anywhere?

I tried to re-built the example flight. I get a vertical trajectory, but I have a problem with importing the wind file. I downloaded the GRIB data, but I receive an error.

Anybody an idea?

Thanks for this great effort!

It looks like wind.py uses a deprecated attribute, line 47 may need to change to:
features = model["polynomialfeatures"].get_feature_names_out()

See: https://scikit-learn.org/stable/whats_new/v1.0.html#version-1-0
"scikit-learn from verson 1.0 get_feature_names is deprecated, use get_feature_names_out"

But then, running the example gives an error:
File "/.../wind.py", line 57, in
eval(f, {}, {"x0": x, "x1": y, "x2": h}) * c
File "", line 1, in
NameError: name 'x' is not defined

I haven't managed to find out why

Thanks for this great addition to openap
I would be interested to understand how to create a specific weather file for a given date and time using xarray. I am new to the cfgrib library.
Would you also recommend to create a more complex sklearn model including time?
On a long flight, it might be better to use a more representative wind speed.

I got the following issue when trying to use MultiPhase

Here is the problem I am facing:

openap-top git:(galleon/fixdoc) ✗ python test/my_example.py
Define optimizer...
Traceback (most recent call last):
  File "test/my_example.py", line 36, in <module>
    flight = optimizer.trajectory(objective=("ci:90", "ci:10", "ci:20"))  # Multiphase
  File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/openap/top/full.py", line 410, in trajectory
    d = np.sqrt(np.sum(((dfde.iloc[0] - dfcr.iloc[-1]) ** 2).values[1:3]))
  File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/pandas/core/indexing.py", line 931, in __getitem__
    return self._getitem_axis(maybe_callable, axis=axis)
  File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/pandas/core/indexing.py", line 1566, in _getitem_axis
    self._validate_integer(key, axis)
  File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/pandas/core/indexing.py", line 1500, in _validate_integer
    raise IndexError("single positional indexer is out-of-bounds")
IndexError: single positional indexer is out-of-bounds

Traceback (most recent call last):
File "flight_planning_domain.py", line 448, in
c2 = Cruise("A388", origin, (35.202362, 65.405415), 0.8)
File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/openap/top/cruise.py", line 15, in init
super().init(*args, **kwargs)
File "/Users/alleon_g/.pyenv/versions/scikit-decide/lib/python3.8/site-packages/openap/top/base.py", line 43, in init
self.lat2, self.lon2 = ap2["lat"], ap2["lon"]
TypeError: 'NoneType' object is not subscriptable

Indeed origin is used twice in base.py. I will submit a fix