jucacrispim / mongomotor Goto Github PK

Hi @jucacrispim ,

I'm working on a large project involving MongoDB and MongoEngine. We are about to refactor our code in order to make Mongo queries asynchronous. mongomotor is the solution to our problem and we are almost about to integrate it in our project.

The project is a professionnal project, this means that we would report bugs, propose pull requests, etc. We would be contributors to your project.

Unfortunately, our project is distributed under a proprietary licence, which is not compatible with GPL 3 - the licence of mongomotor.

Question : would you mind changing mongomotor's license from GPL 3 to something like Apache or MIT?

I ask the question because you may have chosen GPL 3 ...

• for strong reasons (like you do not want mongomotor to be included in proprietary software)
• "as a default choice" because you did not know which open source licence to choose and GPL 3 sounded like a good choice but are not against changing it.

Let me know your point of view. We'll decide to continue with mongomotor if changing the licence is ok for you, or we'll continue our investigations in order to find the right module for our needs.

Damien

Motor 2 has breaking changes and mongomotor must be changed. Gridfs support must be refactored

Using mongo 3.6+, the session stuff is broken.

When a reference is already cached, it is returned imediately not, by a future.

RROR:asyncio:Task exception was never retrieved
future: <Task finished coro=<Slave._process_info() done, defined at /home/deployer/toxicmaster-env-py35/src/toxicbuild/toxicbuild/master/slave.py:172> exception=TypeError("object Repository can't be used in 'await' expression",)>
Traceback (most recent call last):
File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
result = coro.send(None)
File "/home/deployer/toxicmaster-env-py35/src/toxicbuild/toxicbuild/master/slave.py", line 184, in _process_info
await self._process_build_info(build, info)
File "/home/deployer/toxicmaster-env-py35/src/toxicbuild/toxicbuild/master/slave.py", line 193, in _process_build_info
repo = await build.repository
TypeError: object Repository can't be used in 'await' expression

Does mongomotor provide a way to connect with an io_loop explicitly. If not its a good to have enhancement. Since it would be very useful to use mongomotor along with third party async frameworks like sanic.

@app.listener('before_server_start')
def pre_hook(app, loop):
      connect('<mongo_url>', io_loop=loop)

tornado should be an optional dependency and should be installed only as an extra.

I need to patch the signals in mongoengine so it accepts coroutines