jssucks / betterdiscordapp

Better Discord App enhances Discord desktop app with new features.

BetterDiscordApp

betterdiscordapp's Issues

[Bug] BDV2 Javascript Error

Checking for permissions in group chat[Bug]

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Describe the bug
Trying to send a message in a group chat results in BetterDiscord putting the message into the void because of a check for permissions which of course doesn't work.
(Edit) Only happens if Emotes are enabled but also if no emote is typed in. (no matter if the emotes.json exists)

To Reproduce
try sending a message in a group chat while having emotes enabled and sending images by single emotes (no matter if the emotes.json exists)

Expected behavior
that the message gets send

System information
Discord Stable, BDv2 2.0.0-beta5, Windows

Are you willing and able to fix this?
No

Fix z-indexes for fullscreen modals.

https://github.com/JsSucks/BetterDiscordApp/tree/fullscreen-modals

Theme loader

Add all socket event structs

https://github.com/JsSucks/BetterDiscordApp/tree/master/client/src/structs

[Bug] Themes are unable to import local files to their stylesheet

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Describe the bug

Title explains it all, themes are unable to import local files on the theme's directory with relative path.

To Reproduce

theme/
  background.jpg
  config.json
  index.scss

// index.scss
body {
  background-image: url('./background.jpg');
}

Expected behavior

The relative path should be transformed into the base64'd version of the file that was pointed at.

body {
  background-image: url(data:image/png;base64,d2h5IGRpZCB5b3UgZXZlbiBib3RoZXIgZGVjb2RpbmcgdGhpcywgaXQncyBwb2ludGxlc3MsIHN0b3AgaXQu);
}

Screenshots

No screenshots necessary

System information

Manjaro Linux 5.0.2, Discord Stable

Additional context

plsfix

Are you willing and able to fix this?

Perhaps.

Can't click any of the buttons in CSS Editor

They open no windows or don't seem to do anything or serve any purpose other than to just sit there. There's no dump file to check, they're just as far as I can tell, not working.

Emotes do not work.

Any emotes that are entered are not converted into their respective images, despite emotes being enabled in the settings. The emote lookup tool also does not work.

Touchscreen

I have diagnosed that better discord disables the touchscreen on win 10. Could someone please take a look at this for me.

forEach Error on startup

Using newest stable version of discord / betterdiscord

[Feature] Detachable videos

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

A button to detach a video so you can watch the youtube video/gif/any other video files your friend sent you while replying to someone else without it stopping. There were a couple plugins like this in BDV1 but they're all outdated and not working, and I feel as this should be in core BD anyways.

Describe alternatives you've considered

Additional context

Are you willing and able to implement this?

If I knew how, I would.

Hey, how to install?

I did not find the installer for windows

[Bug] - Latest beta wont load plugins

Latest beta wont load plugins?

not sure where they go so I put them in every single better discord folder and made plugin folders / a folder for the plugin in many cases, is there a change in the directory structure/ plugin functionality that prevents/changes plugin loading?

[Feature] Mac Support

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Is your feature request related to a problem? Please describe.
I'm always frustrated when my pepperonis on my frozen pizza aren't aligned perfectly. On the topic of this ticket though: I know that back in the day there was a version of Better Discord that could run on macOS systems. I'm curious if that's still available, or if there are any plans to bring it back?

Describe the solution you'd like
That this would work with mac.

Describe alternatives you've considered
Not using a mac. But nah, i'm a developer.

Additional context

Are you willing and able to implement this?
Maybe? I'm completely unfamiliar with this code bank.

Windows setup texts are realy small

I tried to install the beta version (BetterDiscordSetup-0.3.0_x64.exe) and the texts are just completly illegible

Buttons seems to work but i don't know what is written

Version :

• BD 0.3.0

Platform :

• Windows 10

Better discord overlay

When I open overwatch, theres a huge thing blocking my game, and the betterdiscord logo can be seen at the bottom right.

Can't make $npm run release

ERROR in ../node_modules/mksnapshot/lib/mksnapshot-call.js
Module not found: Error: Can't resolve 'child_process' in '/home/vvs/install/betterdiscord/node_modules/mksnapshot/lib'
@ ../node_modules/mksnapshot/lib/mksnapshot-call.js 8:10-34
@ ../node_modules/mksnapshot/lib/main.js
@ ../node_modules/asar/lib/snapshot.js
@ ../node_modules/asar/lib/asar.js
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js

ERROR in ../node_modules/asar/lib/asar.js
Module not found: Error: Can't resolve 'original-fs' in '/home/vvs/install/betterdiscord/node_modules/asar/lib'
@ ../node_modules/asar/lib/asar.js 2:39-61
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js

ERROR in ../node_modules/asar/lib/filesystem.js
Module not found: Error: Can't resolve 'original-fs' in '/home/vvs/install/betterdiscord/node_modules/asar/lib'
@ ../node_modules/asar/lib/filesystem.js 2:39-61
@ ../node_modules/asar/lib/asar.js
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js

ERROR in ../node_modules/asar/lib/disk.js
Module not found: Error: Can't resolve 'original-fs' in '/home/vvs/install/betterdiscord/node_modules/asar/lib'
@ ../node_modules/asar/lib/disk.js 2:39-61
@ ../node_modules/asar/lib/asar.js
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js

ERROR in ../node_modules/asar/lib/crawlfs.js
Module not found: Error: Can't resolve 'original-fs' in '/home/vvs/install/betterdiscord/node_modules/asar/lib'
@ ../node_modules/asar/lib/crawlfs.js 2:39-61
@ ../node_modules/asar/lib/asar.js
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js

ERROR in ../node_modules/asar/lib/snapshot.js
Module not found: Error: Can't resolve 'original-fs' in '/home/vvs/install/betterdiscord/node_modules/asar/lib'
@ ../node_modules/asar/lib/snapshot.js 2:39-61
@ ../node_modules/asar/lib/asar.js
@ ./src/modules/packageinstaller.js
@ ./src/modules/modules.js
@ ./src/index.js
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] release: webpack --progress --colors --config=webpack.production.config.js
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR! /home/vvs/.npm/_logs/2018-11-25T16_19_28_034Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build_release: npm run release --prefix client && npm run build --prefix core && npm run release --prefix csseditor
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] build_release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/vvs/.npm/_logs/2018-11-25T16_19_28_078Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] release: npm run lint && npm run build_release && gulp release && npm run package_release
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/vvs/.npm/_logs/2018-11-25T16_19_28_126Z-debug.log

npm --version
6.4.1

[Bug] Can't install plugins or themes

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Describe the bug
So I tried downloading some of the Dummy Plugins/Themes, none of them worked, couldn't preview them either, however I could go to the source. I also tried downloading some of @mwittrien's plugins, none of those worked either, so I don't know if I installed them incorrectly, there's something wrong with bd, or if none of the plugins I downloaded happen to work. The plugins show up in installed, but don't work and there's no settings button like there was in a preview Jikks posted a while back

To Reproduce
Just try downloading a plugin

Expected behavior
The plugin to download/work.

Screenshots

Neither of the circled buttons do anything

System information
Windows 10, Discord stable, BDV2 2.0.0-beta.5

Are you willing and able to fix this?
No, I don't know how to fix it 😛

[Bug] _process.default.getuid is not a function

Describe the bug
When starting discord after injection, a javascript error appears saying that _process.default.getuid is not a function at TEST_ARGS

To Reproduce
install betterdiscord via the wiki

Expected behavior
Discord launches with betterdiscord installed

Screenshots

System information
Windows 10 x64 LTSC, Discord Canary build 35059

Are you willing and able to fix this?
no

Installer

Crossplatform installer using Discord's electron so we don't have to pack our own.

CSS Editor

I already have it mostly done before so I'll just have to implement it.

Themes are broken

So when I tried to load up discord the themes where there,but it wasn't transparent and most of the theme was the original theme and I don't know if the plugin needs to be updated or BetterDiscord is down right now.If anyone can help me with this issue I would really appreciate it!

Support for Discord Public Test Beta

I'm using the portable version of Discord.
When trying to install BetterDiscordApp the installer crashes:
C:\Users\ezpz\AppData\Roaming\discord - Directory not found

The test/beta version of Discord uses the following path to store its data:

C:\Users\ezpz\AppData\Roaming\discordptb

I tried to build BetterDiscordApp on my own - but w/o success - otherwise I'd adjust the path & try it again with my own build.

Would be nice to have support for the ptb version aswell.
In case I get the build to work & I can fix the path issue, I can contribute this via PR (if desired)

Regards

Scss compiler

Add a scss compiler and bases

[Bug] Theme Settings broken and Preset Images

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Describe the bug
Trying to change settings of a theme which got packed as a .bd results in an error thrown because the style file not being able to found in the tmp folder. Also the preset images aren't working for a bd compiled theme.

To Reproduce
Install a bd packed theme.
Open the settings and try to change a value.

Expected behavior
The theme gets recompiled using the selected settings.

Screenshots

System information
Windows 10, Discord Stable, BDv2-2.0.0-beta5

Additional context
The theme is written in scss with an icon and 3 schemes jpg's and one pdn image

Are you willing and able to fix this?
No I'm not

Latest Discord Updates deleted BetterDiscord

Help

Unpack websocket payloads correctly

CSS Editor taking too much to update.

It's kinda annoying having to wait 5sec or more for it to refresh the code, could it be there be at least a setting for real time refreshing?

Test

test

Download node through command prompt using curl??

Would it be possible to download node using a CURL request instead of openning the browser? I tried it using the command prompt and it worked perfectly so I suppose it would work in node too.
I used the followind command to download node:
curl https://nodejs.org/dist/v9.11.1/node-v9.11.1-x64.msi > node-v9.11.1-x64.msi

I think the code process would be like following:
Download node using curl. Once it's downloaded run the installer. Wait for the node installer process to be ended. Check if node has been correctly installed. And then....

It's just a suggestion, I don't really know how it's working actually and I don't even know if it would be possible. I thought maybe it could be helpful... and maybe not... i don't know.

Material icons resolve

Fix material icons resolve for travis.

No matter what I do, I get this error now and my theme won't load... :/

CSP Blocks recaptcha

Refused to load the image 'https://www.google.com/recaptcha/api2/*' because it violates the following Content Security Policy directive: "img-src https://cdn.betterttv.net https://cdn.frankerfacez.com".

Posting as an issue because it's funny. Guess add doesn't work after all.

CSS Editor Scrollbar hard to click on

So I dunno if it is only on my end but it's really hard to hit scrollbar with the mouse as windows resizing kicks in there's a 1px or something, spot I can hit to get it going up and down but besides that, I struggle.

Schemes for themes

Themes should have the ability to have predefined schemes in config that set all variables to the schemes values.
I'll do it later unless someone else wants to.

Separate db for sass cache?

Maybe?

Issues with Patcher

Currently the patcher uses IDs for keeping a record of what has been patched using ${displayName}:${functionName}:${caller}. However if a plugin (same caller name) were to use the patcher on two different modules with the same function name the ID might be the same. A large number of internals have switched over to one letter displaynames such as t or repeating displayNames like FluxContainer(t). If a plugin were to try and patch say componentDidMount of multiple of these it would add a child patch to the wrong patch because it would think it's the same module.

The other issues involve checking the return of instead patches or slave patches.

I already have a fixed version of the Patcher that I can PR. I just need to double check existing patches because for some reason they're using hardcoded IDs.

Webhook test

Cleanup/refactor scss

It's ugly and all over the place

[Bug] JavaScript error on startup

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Potentially related to #316 .

Describe the bug
When Discord is started up as according to Windows Task Manager, Discord will boot up with a JS "Uncaught Exception" error message. When the error is cleared, Discord will start up normally, but BDv2 will get stuck in the loading phase.

To Reproduce

1. Make sure Discord runs at startup (Task Manager>Startup>Discord>Status=Enabled).
2. Turn off your computer and then boot it up to your desktop.
3. Wait for Discord to start up.
4. A JS error will appear, as shown in the screenshot.
5. Click "OK"
6. Discord will then start up.
7. BDv2 will get stuck loading, and its logo flashes.

Expected behavior
BDv2 should be able to start up with Discord without errors.

Screenshots

System information
OS: Windows 10 Build 1809 x64
Discord Version: Whatever the latest version was as of 3/15/2019, 8:44 PM PT.
BDv2 Version: 2.0.0-beta.5

Additional context
Workaround: Close Discord completely (Ctrl+R doesn't work) and restart it.

Are you willing and able to fix this?
I am not able to fix this, but I will try my best to help the devs solve this issue.

Precompiled list of module props to be used with WebpackModules.getModuyleByName

Create a precompiled list of module props that can then be used to fetch modules by name instead of props.

Could anyone help teach me how to make a discord theme? I would like to make my own but I don't see anything telling me how

[Bug] idk

Sorry, I don't use GitHub at all.
https://cdn.discordapp.com/attachments/536389434543833098/553708392284160005/2019-03-08_16-19-21.gif
https://cdn.discordapp.com/attachments/536389434543833098/553708390690455552/2019-03-08_16-19-58.gif
(Clicking "Server Discovery" got rid of the "New" notification)

I tried to install a theme but it is not showing up

Hey there,
I just found out about this today and wanted to give it a try. I downloaded it, I see it in my discord, but wasn't sure how to install a theme so I looked around and found C:\Users\Me\AppData\Local\BetterDiscord\ext\themes and put it there, I restarted discord but I do not see it in the list?

Did I miss a step or is this not the fork I should be using? The main betterdiscord.net page linked to here, so I thought this was what I should be using since it said the original was no longer maintained.

Thanks!
-MH

[Bug] Colored text activated at install but not shown as

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Describe the bug
In BD 2.00 beta 6 "Colored text" is activated but not shown as

To Reproduce
Idk :/ Just installed beta 6 and it happened.

Expected behavior
Just not it to be activated.

System information
Windows 10 x64
Discord PTB

Are you willing and able to fix this?
nope

Installing plugins and themes

How do i install plugins and themes?

[Feature] When no key is inputed, clicking the lock should open a prompt to add a key to the active channel.

• Used appropriate template for the issue type
• Searched both open and closed issues for duplicates of this issue
• Title adequately and concisely reflects the feature or the bug

Is your feature request related to a problem? Please describe.
As of currently, the lock when a key is added to a channel will open a prompt with additional options. When there is no key for a channel, clicking the lock does nothing.

Describe the solution you'd like
If there is no key for a channel, and the user wants to add one, they should be able to do so by clicking the red lock icon and entering the key that way, instead of going into the settings, opening an entry and entering the key. This is solely a QoL improvment that saves a few steps on the user's end.

Describe alternatives you've considered
N/A

Additional context
N/A

Are you willing and able to implement this?
No, but I am willing to help the devs in any way rationally possible.

Installing BetterDiscord

How to install BD? Probably I am an idiot and it's very easy, but idk how to do that. Can someone help?

Module not found: Error: Can't resolve 'child_process'

ERROR in ../node_modules/mksnapshot/lib/mksnapshot-call.js
Module not found: Error: Can't resolve 'child_process' in '/home/spaceboyross/BetterDiscordApp/node_modules/mksnapshot/lib'
 @ ../node_modules/mksnapshot/lib/mksnapshot-call.js 8:10-34
 @ ../node_modules/mksnapshot/lib/main.js
 @ ../node_modules/asar/lib/snapshot.js
 @ ../node_modules/asar/lib/asar.js
 @ ./src/modules/packageinstaller.js
 @ ./src/modules/modules.js
 @ ./src/index.js

Tooltip positioning

Fix tooltip positions when container is not wide enough without adding static margins.