jsrmath / sharp11 Goto Github PK

When writing the code to convert between notes and MIDI values, I used this reference which annoyingly considers C5 to be Middle C, unlike everyone else who considers it to be C4.

Hey there!

First of all, congratulations for the awesome work you did here.

Second, I've been reading chord.js. I see ninths are either aug, m or M (lines 103-116). This way you either have #9 or b9, not both.

So, in the sharp11-client if you write C11b9#9, it'll be assumed to be a C11#9. However, if you add the note C#, the output you get is indeed C11b9#9.

Shouldn't that be solved?

I know I could easily hack the scale list, but being able to use arbitrary scale would make this even more useful. For example, the augmented scale has another version [m2 3 4 aug5 6].

It would also be quite useful to be able to deal with pitches as integers, for example a 9 note scale [0 1 3 4 5 7 8 9 11]

I'm willing to contribute, if that's useful.

Chord objects should have a way to retrieve the original chord symbol without any aliases handled.

Why shouldn't it be possible to calculate interval between for instance C# and Gb and get a P4 (perfect 4th)? what I do for the moment is that I convert Gb to F#, but I guess it should be possible.

Likely has something to do with range checking. Hard to reproduce.

Does this library have any such facility to get all the possible chords from a note set?