Ensure that the JSON object is complete about jsonmapper

[DannyvdSluijs]

@CReimer I think the rough outline of steps would be:

• Create a new middleware (with some meaningfull name)
• Define the logic you need (the $json will hold the data and the $propertyMap contains the results of earlier executed middleware such a TypedProperties and DocBlockAnnotations. Using something like array_keys($propertyMap->getIterator()->getArrayCopy()) you can get the names of the properties and use them in an array_diff against the keys of the Json to find the missing properties from the Json
• Add a specific Exception that can hold the data that is required by consumers of the package
• You can then add some feature tests that confirm the expected results.
• Optionally you can extent the JsonMapperBuilder with some method to add the middleware.

No worries if you can't figure it out. I can help if needed Im just rather occupied ATM. You could also work in a TDD approach and just provide the testcase and I can take it from there when I find the time.

[DannyvdSluijs]

Hi @CReimer

Thanks for the report and also apologies for the later reply but due to my holidays and moving into a new house my time was consumed with other items.

I think it would not be core functionality of JsonMapper but something which can easily be done using a new middleware that compares the keys of the given JSON and take the non-nullable properties of the property map and see if any keys are missing. The you can either throw the exception or keep track of the exceptions (to avoid running into issues with multiple mappings) and use the FinalCallback to due something with the collected exceptions.

I do see the added value in this but am rather curious how you would use this in production systems where (external) misinformed data would lead to an exception?

Also would you be willing to make a pull request for this?

[CReimer]

I do see the added value in this but am rather curious how you would use this in production systems where (external) misinformed data would lead to an exception?

That's exactly my point. My goal is to terminate the request with an HTTP 400 Bad request or something else in the 4xx range.

Also would you be willing to make a pull request for this?

Yeah, of course. But can you give me some pointers first? Where should I start?