Making own middleware - a bit unclear how to do so… about jsonmapper

[DannyvdSluijs]

Thanks for you input @alexkuc given you looking for answers I guess making the PR will be difficult. I’ll see when I have time available to sort it. Any specific question that is blocking you now?

[alexkuc]

@DannyvdSluijs thank you for the fast response. I am currently going over source code of the existing middleware. I'll let you know if I get stuck with something. Thank you again.

[alexkuc]

@DannyvdSluijs I managed to put something myself together. I think I got the general gist of the approach. Would you be open to PR to update docs?

[DannyvdSluijs]

PR are more than welcome. That is the power of open source.

[alexkuc]

@DannyvdSluijs I was about to start writing new README page but I just realised something so wanted to double check with you:

JsonMapper/src/JsonMapperInterface.php

Line 11 in 54ac9f7

public function push(callable $middleware, string $name = ''): self;

As far as I can tell JsonMapperInterface does not really enforce middleware type, it's purely by convention that middleware should use MiddlewareInterface and MiddlewareLogicInterface?

[DannyvdSluijs]

Hi @alexkuc

I've been busy so you'll have to excuse me for my late reply.
Your assumptions are correct. This has been an oversight which i want to address at some point but since that would impact others as well that should only be done in a new mayor release.

[DannyvdSluijs]

@alexkuc I wanted to check with you if you still need any help, either in understanding JsonMapper or in opening a PR?

[alexkuc]

@DannyvdSluijs all is good