jsagardoy / ejercicio Goto Github PK

• It would be nice to use English as default language for variable, files and functions, commit messages, etc.
  • generarColores would be createColorPallete
  • oscurecercolores would be getDarkerColor
  • aclararColores would be getLighterColor
• Add a .gitignore file to prevent uploading compiled and other libs (like compiled_css, node_modules, etc).
• It would be nice to pass $color as a variable to generarColores to allow multiple color palletes (with this change you should use $color-dark-$i and $color-light-$i), even (optionally) $howManyColors to create dynamic color ranges.
• You can move _formatos.scss content to main.scss and remove titulo3 and formatoContent mixins (Mixins are meant to be include reusable chunks of code, but h3, .color and .container classes are used once)
• Add to README.md a "how to use this repo to see your results" It would be:

How to use

1. Clone this repo (You will need to have Node.js installed)
2. Open a command prompt inside project folder.
3. Execute npm install to install dependencies
4. Execute npm run sass to build CSS
5. Execute npm start to see the result (You can open [http://localhost:9005](http://localhost:9005] if your browser doesn't open automatically.

Overall you did a great job with the color palette 👍! Keep it up!