Comments (5)
So you want me to fix bugs, you introduced yourself?
Shall I revert your PR #28?
from django-sass-processor.
No definitely not, I was looking for your input and am used to creating an issue when I've found one. Because I might pick it up the next day or after lunch if I couldn't find a fix immediately.
The property SassSrcNode.source_file
checks whether SassSrcNode._source_file
is set not None
and that variable is only set when using Jinja2. Else it reverts back to self.source[0].name
which was in the original code. This is initialised in the Template constructor but I don't see any reference to it in the Node
class.
This looks like it might also be an issue prior to the version with Jinja2 support so I thought you might know more that could help me fix the issue. I plan to help maintain the django-sass-processor beyond the Jinja2 support.
from django-sass-processor.
Well, then I apologize for misinterpreting git blame
. Accessing an uninitialized attribute was part of your PR. Hmm, so where does that attribute come from? So it must be from the base class. Do you want to check this? Maybe it changed with one of the newer Django versions.
from django-sass-processor.
@AndreasBackx can we close this?
from django-sass-processor.
@jrief my apologies. From the top off my hat this error happened when the SASS file couldn't be found. It threw this error while throwing that one. I could be wrong, best to test it out but it isn't a priority. Afaik the source file isn't used anywhere but in throwing that exception.
from django-sass-processor.
Related Issues (20)
- Auto-compile stops for unknown reason HOT 2
- FILE_CHARSET is removed in Django 3.1 HOT 3
- LibSass is deprecated HOT 3
- Remove note about Django 3.0 compatibility from the readme HOT 1
- Q: Compile to media storage instead of static? HOT 11
- sass_inline HOT 7
- Invalid setting 'base_url' for S3StaticStorage (from django-storages) HOT 4
- import statement in SCSS file not working with v1.0.1 HOT 1
- Compilescss failed with a lot of "non sense" errors HOT 8
- CSS not updating when DEBUG=True until I erase existing css files in Docker container HOT 1
- sequence item 1: expected str instance, WindowsPath found HOT 4
- Regression: Use of custom storages broken HOT 11
- Why does compilescss create two files HOT 1
- TypeError when using Google backend from django-storages HOT 1
- Web Page Rendering After Installation & Installation is Messed Up HOT 2
- Import-only files are not monitored for changes HOT 7
- Deprecation of STATICFILES_STORAGE in django 4.2 HOT 1
- Third party documentation no longer available HOT 7
- Error sometimes occurs when trying to compile scss
- Broken in Django 5.1 alpha due to get_storage_class HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-sass-processor.