Coder Social home page Coder Social logo

Comments (5)

jrief avatar jrief commented on July 22, 2024

So you want me to fix bugs, you introduced yourself?
Shall I revert your PR #28?

from django-sass-processor.

AndreasBackx avatar AndreasBackx commented on July 22, 2024

No definitely not, I was looking for your input and am used to creating an issue when I've found one. Because I might pick it up the next day or after lunch if I couldn't find a fix immediately.

The property SassSrcNode.source_file checks whether SassSrcNode._source_file is set not None and that variable is only set when using Jinja2. Else it reverts back to self.source[0].name which was in the original code. This is initialised in the Template constructor but I don't see any reference to it in the Node class.

This looks like it might also be an issue prior to the version with Jinja2 support so I thought you might know more that could help me fix the issue. I plan to help maintain the django-sass-processor beyond the Jinja2 support.

from django-sass-processor.

jrief avatar jrief commented on July 22, 2024

Well, then I apologize for misinterpreting git blame. Accessing an uninitialized attribute was part of your PR. Hmm, so where does that attribute come from? So it must be from the base class. Do you want to check this? Maybe it changed with one of the newer Django versions.

from django-sass-processor.

jrief avatar jrief commented on July 22, 2024

@AndreasBackx can we close this?

from django-sass-processor.

AndreasBackx avatar AndreasBackx commented on July 22, 2024

@jrief my apologies. From the top off my hat this error happened when the SASS file couldn't be found. It threw this error while throwing that one. I could be wrong, best to test it out but it isn't a priority. Afaik the source file isn't used anywhere but in throwing that exception.

from django-sass-processor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.