Comments (7)
I agree that inlining CSS is bad practice. The argument about network speeds does not hold, because the requested file will be cached (in constrast, it is transmitted over the wire for every single page load if inlined).
Encouraging such bad practice is beyond the scope of django-sass-processor, imho ;). Closing this issue as @jrief seems to agree.
from django-sass-processor.
Tested django-sass-processor===0.8.2
on Django 3.2 and manifested issue was not there.
from django-sass-processor.
The problem with inlining is, that you still have to create the file. That's what you do in your example. Then however that content always will be included into the rendered HTML, otherwise the browser will cache the generated CSS file.
If you have concerns about slow networks and additional requests, go ahead and use django-compressor with django-sekizai.
Another approach is to use HTTP/2.0, there all requests are handled by in the same TCP/IP session.
from django-sass-processor.
he argument about network
Where it would be cached? Are you aware of the Google Page speed insight and May 21 SEO update? It loads simulation with a clear cache like a new user comes to read your content. So there will be no browser cache and PSI (lighthouse) simulates throttled network with big ping, so if you think your CDN will cache it be aware you will have ping time to CDN server, because of throttled delay. and you will double request the time of the critical render path.
I agree that inlining CSS is bad practice
I even can't guess why you think so because it is well-known best practice:
(copy you can google what is web dev and understand their role influence and role in tech)
https://web.dev/extract-critical-css/
Though HTTP 2 might solve it, but for me sounds like a well-known and recommended inlines much simpler and more compatible approach
from django-sass-processor.
from django-sass-processor.
How many of the page loads made from your application are first page loads of new users?
There are a lot of niches where it is critical like SEO.
Viral content, any marketing porpuses of Django websites wants EMPTY users, new users, new clients some of them will go down to funnel. Each new empty user might be bounced because of a white page duren several seconds.
https://www.searchenginewatch.com/wp-content/uploads/sites/25/2018/07/think-with-Google.jpg
Well, if you wish to challenge your new "empty cache and mobile network" users or blog readers for patience before inviting to sail funnel then your are thinking right π
from django-sass-processor.
Well, if you wish to challenge your new "empty cache and mobile network" users or blog readers for patience before inviting to sail funnel then your are thinking right wink
Your argumentation might hold for websites that mainly deliver content (and if speed matters, really should be built into static pages instead of going through a full-blown Djangoβ¦). I do not think that this is the scope of django-sass-processor β frameworks aiming at delivering content websites through Django will rely on SEO mechanisms, including inlining of content where it makes sense. We do not need t ocopy such functionality into django-sass-processor.
from django-sass-processor.
Related Issues (20)
- Auto-compile stops for unknown reason HOT 2
- FILE_CHARSET is removed in Django 3.1 HOT 3
- LibSass is deprecated HOT 3
- Remove note about Django 3.0 compatibility from the readme HOT 1
- Q: Compile to media storage instead of static? HOT 11
- Invalid setting 'base_url' for S3StaticStorage (from django-storages) HOT 4
- import statement in SCSS file not working with v1.0.1 HOT 1
- Compilescss failed with a lot of "non sense" errors HOT 8
- CSS not updating when DEBUG=True until I erase existing css files in Docker container HOT 1
- sequence item 1: expected str instance, WindowsPath found HOT 4
- Regression: Use of custom storages broken HOT 11
- Why does compilescss create two files HOT 1
- TypeError when using Google backend from django-storages HOT 1
- Web Page Rendering After Installation & Installation is Messed Up HOT 2
- Import-only files are not monitored for changes HOT 7
- Deprecation of STATICFILES_STORAGE in django 4.2 HOT 1
- Third party documentation no longer available HOT 7
- Error sometimes occurs when trying to compile scss
- Broken in Django 5.1 alpha due to get_storage_class HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-sass-processor.