jrahmatinl / poolstagesimulator Goto Github PK

This method is a little too large. In general, methods over 20 lines of code indicate a code smell & may become hard to follow.

Someone noted that sometimes one team end up first in the list without scoring points.

Currently, all existing competition managers are setup to use the ICompetitionManager.RunCompetition method with a participant & an opponent as parameters. This doesn't allow matches with more than 2 teams & is only usable for games like hockey, soccer, Ammerican football etc.

A quick search on stackexchange suggest that having more than 2 teams is possible in some sports & games, so it would nice to support this so that the simulator becomes more generic.

The play method in the PoolStageSimulator is too bloated & has too much responsibility. None of the code in the simulator actually seems to be doing any simulation.

At the very least the play method should be split into multiple shorter methods.
Consider doing something with random value generation mentioned in issue #1 Instead of doing things like composing pool stage results that don't belong in the simulator!

BestTeamsWinMostOfTheTimes makes a guesses the test to be correct if the best teams end up more than twice. It might be better to mock some values instead.

Maybe in such a way that the best teams have a worst and best case scenario, only loose one match by accident, but compromise with points in the remaining matches.

Some links that might help achieve this are:
https://github.com/nunit/docs/wiki/Random-Attribute