jpommerening / grunt-run-task Goto Github PK

A multi task that was created without a specific target can never switch from one target to another:

var task = runTask.task('multi');

task.run('target1', done); // runs "multi:target1"
task.run('target2', done); // runs "multi:target1" (again)

Maybe we should just enforce that a multi-task is created with a specific target:

var task = runTask.task('multi'); // throws, needs target
var task1 = runTask.task('multi:target1'); // ok
var task2 = runTask.task('multi:target2'); // ok

callback method is never called for all multitasks that do not implement the async pattern.

the issue is in index.js line 161... grunt.task.start({asyncDone: true});

It is forcing grunt to wait for an async callback which never happens.

i've set this to false for now and seems to work.
grunt.task.start({asyncDone: false}); //<< change asyncDone to false.

When trying to run the default task (as per example) the runtask crashes.

EXAMPLE------------------------------------
runTask('htmlmin', {
default: {
"files": filesToMinify
}
}, function (err) {
if (err) console.log(JSON.stringify(err));
});

RESULT----------------------------------------------
target = task.target || Object.keys(config)[0]
^
TypeError: Object.keys called on non-object
at Function.keys (native)

FIX (1/2)---------------------------------------
Change Line 139 in index.js
target = task.target || (config ? Object.keys(config)[0] : 'default') || 'default';

FIX (2/2)
Include default task name
runTask('htmlmin:default', {

For some weird reason, when I use this in Mocha, the test always timeout and the callback is called after the test failed, regardless of how long the timeout is.

There seems to be a problem with the mock output stream used for logging.
The setting {muted: true} causes task output to never reach the buffer.

http://gruntjs.com/blog/2016-02-11-grunt-1.0.0-rc1-released

How about changing the Grunt dependency to >=0.4.0 in package.json?

When instead of using runTask directly, I use the runTask.task and task.run methods, in combination with a multiTask, grunt-run-task tries to execute the wrong target

I created an example to showcase the issue
https://gist.github.com/alebianco/85500551f92bcc578a3328f013c1833a

i'm running with node 6.0.0