jpbulman / advanced-sets

A JS/TS library that expands upon the functionality of Sets

Hi there 👋

My name is JP, I'm currently a backend .NET developer at Draftkings. In my free time, I like to work on web projects.

advanced-sets's Issues

.powerSet()

It'd be nice to have a method that returns an array, or iterable, of sets that are all the permutations of the elements of the set (a.k.a. the power set)

e.g.

const setA = new AdvancedSet(1, 2, 3)
setA.powerSet() // [AS(), AS(1), AS(2), AS(3), AS(1, 2), AS(1, 3), AS(2, 3), AS(1, 2, 3)]

Create subset by condition

It'd be nice to have createSubset be able to take in the list of values (current) or a condition function that defines what elements to keep

Proper subsets and supersets

There are methods to check if another set is a subset and superset, so there should also be methods that check for proper subsets and proper supersets

Delete multiple items

The add function takes in a variable number of arguments, delete should as well

Support varargs .add()

Currently, .add() only accepts one argument. It should be able to accept any number of arguments.

Too much temporary data and inefficient operations

Consider using the standard .values instead of the custom .toArray. Besides, I'd also suggest to use Set's methods as much as possible since it is implemented as a hashset, which is very efficient, instead of relying on Array's methods which usually take at least linear time.

For example, .intersection could be implemented along the following lines

intersection(s1, s2) {
  s3 = new Set();
  s1.forEach(value => {
    if (s2.has(value)) {
      s3.add(value);
    }
  });
  return s3;
}

Allow for multi set intersection

Current behavior:
Can only find the intersection between two sets

setA.intersection(setB)

Desired behavior:
Find the intersection between n sets

setA.interesction(setB, setC, setD, ...)

Min and Max functions

Could be useful for sets of numbers

Add support for ForOf loops

Add some and every functions

Would help a lot with some of the other internal methods that currently use filters or loop over items