jpavlav / uptimerobotpy Goto Github PK

Do you know how to set POST value in Web-hook Alert Contact?
There is only value field, but Web-hook (type = 5) has option POST Value (JSON format. In Web GUI it's working, but via API not.

What good library is truly good without tests? Going to get some unittests written out for this one.

Hey @jpavlav, thanks for UptimeRobotPy. It has been of great use for me. Unfortunately editing existing monitors does not seem to work or I'm doing something wrong. Steps to reproduce:

1. create a monitor (new_monitor) with an interval of e.g. 600
2. update this monitor (up_robot.edit_monitor(identifier, interval=1200)) with an interval of e.g. 1200
3. query the monitor (get_all_monitors)
4. the interval of the monitor is still at 600

This seems to apply to all parameters except friendly_name which works correctly.

Tried to change the interval using a cURL request which worked well so it's probably not an upstream issue. Let me know if you need more info.

Considering changing how payloads are handled. Utilizing locals() allowed for some pretty code and less lines overall, but considering the number of possible arguments to many of the calls related to creation or editing of resources such as monitors, psp's, etc, it might be better to create separate classes representing each type of payload.

The classes could have as their attributes the possible arguments to the API call itself. This would demystify things a bit. More code, less concise. More readable, probably less prone to error. Likely going to start working on a refactor to support these ideas.

Have had some experience with TravisCI and that's likely the direction I'm headed with this one too. After tests are written, going to get CI going.